From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Kumar Amit Mehta <gmate.amit@gmail.com>
Cc: gregkh@linuxfoundation.org, wfp5p@virginia.edu,
geert@linux-m68k.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] staging: dgrp: dgrp_tty.c: return an -EFAULT if put_user fails
Date: Wed, 14 Nov 2012 11:57:35 +0000 [thread overview]
Message-ID: <20121114115735.19883baf@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <1352874741-18526-1-git-send-email-gmate.amit@gmail.com>
On Wed, 14 Nov 2012 12:02:21 +0530
Kumar Amit Mehta <gmate.amit@gmail.com> wrote:
> This fix adds checks for inspecting the return value of put_user() and return
> -EFAULT on error.
>
> Signed-off-by: Kumar Amit Mehta <gmate.amit@gmail.com>
> ---
> drivers/staging/dgrp/dgrp_tty.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/dgrp/dgrp_tty.c b/drivers/staging/dgrp/dgrp_tty.c
> index e125b03..b294197 100644
> --- a/drivers/staging/dgrp/dgrp_tty.c
> +++ b/drivers/staging/dgrp/dgrp_tty.c
> @@ -2265,7 +2265,8 @@ static int get_modem_info(struct ch_struct *ch, unsigned int *value)
> | ((mlast & DM_RI) ? TIOCM_RNG : 0)
> | ((mlast & DM_DSR) ? TIOCM_DSR : 0)
> | ((mlast & DM_CTS) ? TIOCM_CTS : 0);
> - put_user(mlast, (unsigned int __user *) value);
> + if (put_user(mlast, (unsigned int __user *) value))
> + return -EFAULT;
return put_user(mlast, ....)
is shorter and neater and does the same thing.
Alan
prev parent reply other threads:[~2012-11-14 11:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-14 6:32 Kumar Amit Mehta
2012-11-14 11:57 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121114115735.19883baf@pyramind.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=devel@driverdev.osuosl.org \
--cc=geert@linux-m68k.org \
--cc=gmate.amit@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®