mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Boris Ostrovsky <boris.ostrovsky@amd.com>
Cc: hpa@zytor.com, mingo@elte.hu, tglx@linutronix.de,
	herrmann.der.user@googlemail.com, bp@alien8.de,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86, microcode, AMD: Add support for family 16h processors
Date: Thu, 15 Nov 2012 18:45:03 -0200	[thread overview]
Message-ID: <20121115204503.GB18032@khazad-dum.debian.net> (raw)
In-Reply-To: <1353004910-2204-1-git-send-email-boris.ostrovsky@amd.com>

On Thu, 15 Nov 2012, Boris Ostrovsky wrote:
> Add valid patch size for family 16h processors
> 
> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@amd.com>

Is this something that needs to go to -stable ?

>  #define F1XH_MPB_MAX_SIZE 2048
>  #define F14H_MPB_MAX_SIZE 1824
>  #define F15H_MPB_MAX_SIZE 4096
> +#define F16H_MPB_MAX_SIZE 3458
>  
>  	switch (c->x86) {
>  	case 0x14:
> @@ -198,6 +199,9 @@ static unsigned int verify_patch_size(int cpu, u32 patch_size,
>  	case 0x15:
>  		max_size = F15H_MPB_MAX_SIZE;
>  		break;
> +	case 0x16:
> +		max_size = F16H_MPB_MAX_SIZE;
> +		break;
>  	default:
>  		max_size = F1XH_MPB_MAX_SIZE;
>  		break;

Because it looks like without this patch, some valid microcode updates
would be rejected by the kernel...

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

  parent reply	other threads:[~2012-11-15 21:40 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-15 18:41 Boris Ostrovsky
2012-11-15 20:24 ` Andreas Herrmann
2012-11-15 20:45 ` Henrique de Moraes Holschuh [this message]
2012-11-15 21:26   ` Boris Ostrovsky
2012-11-15 21:48     ` H. Peter Anvin
2012-11-15 21:49     ` Henrique de Moraes Holschuh
2012-11-15 21:55     ` Andreas Herrmann
2012-11-15 23:01   ` Gene Heskett
2012-11-15 23:35     ` Boris Ostrovsky
2012-11-17 14:41       ` Borislav Petkov
2012-11-17 15:29         ` Henrique de Moraes Holschuh
2012-11-17 15:31           ` Borislav Petkov
2012-11-17 18:34         ` Gene Heskett
2012-11-17 19:41           ` H. Peter Anvin
2012-11-17 20:07             ` Gene Heskett
2012-11-17 20:42               ` H. Peter Anvin
2012-11-17 19:54     ` Andreas Herrmann
2012-11-17 20:11       ` Gene Heskett
2012-11-19 14:23         ` Borislav Petkov
2012-11-15 21:55 ` [tip:x86/urgent] " tip-bot for Boris Ostrovsky
2012-11-21  7:36 ` tip-bot for Boris Ostrovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121115204503.GB18032@khazad-dum.debian.net \
    --to=hmh@hmh.eng.br \
    --cc=boris.ostrovsky@amd.com \
    --cc=bp@alien8.de \
    --cc=herrmann.der.user@googlemail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®