From: Greg KH <gregkh@linuxfoundation.org>
To: Johan Meiring <johanmeiring@gmail.com>
Cc: pe1dnn@amsat.org, jkosina@suse.cz, standby24x7@gmail.com,
viro@zeniv.linux.org.uk, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] staging: wlags49_h2: mdd.h: fixes tons of coding style issues
Date: Fri, 16 Nov 2012 09:06:16 -0800 [thread overview]
Message-ID: <20121116170616.GB30626@kroah.com> (raw)
In-Reply-To: <1353084911-8908-1-git-send-email-johanmeiring@gmail.com>
On Fri, Nov 16, 2012 at 06:55:11PM +0200, Johan Meiring wrote:
> This commit sorts out a ton of styling issues, including the use of
> C99 // comments, spaces before and after tabs, etc. I also took the
> time to align stuff a little more neatly using tabs. The file is
> nowhere near ready, but it's a start.
>
> Signed-off-by: Johan Meiring <johanmeiring@gmail.com>
> ---
> drivers/staging/wlags49_h2/mdd.h | 1593 +++++++++++++++++++-------------------
> 1 file changed, 797 insertions(+), 796 deletions(-)
A patch this big is almost impossible to review, sorry. Please break it
up into smaller pieces.
thanks,
greg k-h
next prev parent reply other threads:[~2012-11-16 17:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-16 16:55 Johan Meiring
2012-11-16 17:06 ` Greg KH [this message]
2012-11-16 17:09 ` Johan Meiring
2012-11-16 17:32 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121116170616.GB30626@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=jkosina@suse.cz \
--cc=johanmeiring@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pe1dnn@amsat.org \
--cc=standby24x7@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome