From: "George Spelvin" <linux@horizon.com>
To: linux@horizon.com, namit2010@gmail.com
Cc: akpm@linux-foundation.org, andrei.emeltchenko@intel.com,
andriy.shevchenko@linux.intel.com, jbeulich@suse.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Lib:The patch include fix for "-" during string to long conversion
Date: 18 Nov 2012 09:04:53 -0500 [thread overview]
Message-ID: <20121118140453.2032.qmail@science.horizon.com> (raw)
In-Reply-To: <CAKMXDJXktVEK1XFa0P+O_EHkt6Uvb9f8UcdasaNyCLPZ+G-GcQ@mail.gmail.com>
Namit Gupta wrote:
> @@ -91,10 +98,18 @@ EXPORT_SYMBOL(simple_strtol);
> */
> long long simple_strtoll(const char *cp, char **endp, unsigned int base)
> {
>
> long l;
>
> if (cp[0] != '-')
> return simple_strtoull(cp, endp, base);
> l = -simple_strtoull(cp+1, endp, base);
In addition to the somewhat ugly the leading blank line,
I'd call this not very well tested.
next parent reply other threads:[~2012-11-18 14:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAKMXDJXktVEK1XFa0P+O_EHkt6Uvb9f8UcdasaNyCLPZ+G-GcQ@mail.gmail.com>
2012-11-18 14:04 ` George Spelvin [this message]
[not found] <CAKMXDJXssksA0dtyfe5dTt0RerZzTWOORWCZCZdJF7WAp56=Ng@mail.gmail.com>
2012-11-04 22:25 ` George Spelvin
2012-11-05 8:26 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121118140453.2032.qmail@science.horizon.com \
--to=linux@horizon.com \
--cc=akpm@linux-foundation.org \
--cc=andrei.emeltchenko@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jbeulich@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namit2010@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®