From: Andrew Morton <akpm@linux-foundation.org>
To: Jingoo Han <jg1.han@samsung.com>
Cc: "'LKML'" <linux-kernel@vger.kernel.org>,
"'Richard Purdie'" <rpurdie@rpsys.net>,
"'Joe Perches'" <joe@perches.com>
Subject: Re: [PATCH] backlight: 88pm860x_bl: remove an unnecessary line continuation
Date: Mon, 19 Nov 2012 14:21:57 -0800 [thread overview]
Message-ID: <20121119142157.620fcfde.akpm@linux-foundation.org> (raw)
In-Reply-To: <004a01cdc5f6$a247bed0$e6d73c70$%han@samsung.com>
On Mon, 19 Nov 2012 10:38:53 +0900
Jingoo Han <jg1.han@samsung.com> wrote:
> This patch removes remove an unnecessary line continuation in
> pm860x_backlight_probe(). Also, a checkpatch warning is fixed
> as below:
>
> WARNING: Avoid unnecessary line continuations
>
> --- a/drivers/video/backlight/88pm860x_bl.c
> +++ b/drivers/video/backlight/88pm860x_bl.c
> @@ -228,7 +228,7 @@ static int pm860x_backlight_probe(struct platform_device *pdev)
> sprintf(name, "backlight-%d", pdev->id);
> data->port = pdev->id;
> data->chip = chip;
> - data->i2c = (chip->id == CHIP_PM8606) ? chip->client \
> + data->i2c = (chip->id == CHIP_PM8606) ? chip->client
> : chip->companion;
> data->current_brightness = MAX_BRIGHTNESS;
> if (pm860x_backlight_dt_init(pdev, data, name)) {
It's still pretty ugly, but looky here:
diff -puN drivers/video/backlight/88pm860x_bl.c~backlight-88pm860x_bl-remove-an-unnecessary-line-continuation-fix drivers/video/backlight/88pm860x_bl.c
--- a/drivers/video/backlight/88pm860x_bl.c~backlight-88pm860x_bl-remove-an-unnecessary-line-continuation-fix
+++ a/drivers/video/backlight/88pm860x_bl.c
@@ -228,8 +228,7 @@ static int pm860x_backlight_probe(struct
sprintf(name, "backlight-%d", pdev->id);
data->port = pdev->id;
data->chip = chip;
- data->i2c = (chip->id == CHIP_PM8606) ? chip->client
- : chip->companion;
+ data->i2c = (chip->id == CHIP_PM8606) ? chip->client : chip->companion;
data->current_brightness = MAX_BRIGHTNESS;
if (pm860x_backlight_dt_init(pdev, data, name)) {
if (pdata) {
_
prev parent reply other threads:[~2012-11-19 22:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-19 1:38 Jingoo Han
2012-11-19 22:21 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121119142157.620fcfde.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=jg1.han@samsung.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome