mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Bill Pemberton <wfp5p@virginia.edu>,
	linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
Subject: Re: [PATCH 407/493] infiniband: remove use of __devexit
Date: Mon, 19 Nov 2012 14:49:22 -0700	[thread overview]
Message-ID: <20121119214922.GA5636@obsidianresearch.com> (raw)
In-Reply-To: <20121119201938.GA5614@kroah.com>

On Mon, Nov 19, 2012 at 12:19:38PM -0800, Greg KH wrote:
> On Mon, Nov 19, 2012 at 01:09:21PM -0700, Jason Gunthorpe wrote:
> > On Mon, Nov 19, 2012 at 01:25:56PM -0500, Bill Pemberton wrote:
> > > CONFIG_HOTPLUG is going away as an option so __devexit is no
> > > longer needed.
> > 
> > I'm sad to hear this, it is an easy space saver on my non-modular
> > emebedded systems :(
> 
> Really?  I asked for details, and it was reported that this only saved
> 1-200 bytes or so.  See the lkml archives for the details of this.

I just checked for you:

Old 2.6.16 powerpc 32 kernel:

   text    data     bss     dec     hex filename
2399368  222224  156124 2777716  2a6274 build/vmlinux
2394634  221804  156124 2772562  2a4e52 build-nhp/vmlinux

That looks like around 5154 bytes to me

New 3.6 powerpc 32 kernel:

   text    data     bss     dec     hex filename
3352356  162812  218132 3733300  38f734 build/vmlinux
3347644  162648  217860 3728152  38e318 build-nhp/vmlinux

And that is about 5148 bytes.

In both cases the only difference is adding CONFIG_HOTPLUG=y to the
config.

5k isn't a lot, but in the context of 'I have to figure out how to
trim ~1MB off the 3.6 kernel to run it in our smallest hardware' it is
the wrong direction :(

Regards,
Jason

       reply	other threads:[~2012-11-19 21:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1353349642-3677-1-git-send-email-wfp5p@virginia.edu>
     [not found] ` <1353349642-3677-407-git-send-email-wfp5p@virginia.edu>
     [not found]   ` <20121119200921.GD1556@obsidianresearch.com>
     [not found]     ` <20121119201938.GA5614@kroah.com>
2012-11-19 21:49       ` Jason Gunthorpe [this message]
2012-11-19 22:06         ` Greg KH
2012-11-19 22:48           ` Jason Gunthorpe
2012-11-19 23:00             ` Greg KH
2012-11-19 23:17               ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121119214922.GA5636@obsidianresearch.com \
    --to=jgunthorpe@obsidianresearch.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=wfp5p@virginia.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome