From: Krzysztof Mazur <krzysiek@podlesie.net>
To: Jean-Francois Moine <moinejf@free.fr>
Cc: Alan Cox <alan@linux.intel.com>,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: vt: regression caused by "Fix line garbage in virtual.."
Date: Tue, 20 Nov 2012 16:20:55 +0100 [thread overview]
Message-ID: <20121120152055.GA5684@shrek.podlesie.net> (raw)
In-Reply-To: <20121120095421.1d4dfa5e@armhf>
On Tue, Nov 20, 2012 at 09:54:21AM +0100, Jean-Francois Moine wrote:
> Thanks for testing. This time, the fix was easy.
>
> But anyway, as it seems that my patch fixes only the Cubox machine and
> as we are still using a kernel 3.5 with specific patches, the fix may
> be delayed.
>
> --->8 ---
> --- a/drivers/tty/vt/vt.c
> +++ b/drivers/tty/vt/vt.c
> @@ -539,25 +539,25 @@
> {
> unsigned short *p = (unsigned short *) vc->vc_pos;
>
> - scr_memmovew(p + nr, p, vc->vc_cols - vc->vc_x);
> + scr_memmovew(p + nr, p, (vc->vc_cols - vc->vc_x) * 2);
> scr_memsetw(p, vc->vc_video_erase_char, nr * 2);
> vc->vc_need_wrap = 0;
> if (DO_UPDATE(vc))
> do_update_region(vc, (unsigned long) p,
> - (vc->vc_cols - vc->vc_x) / 2 + 1);
> + vc->vc_cols - vc->vc_x);
> }
>
> static void delete_char(struct vc_data *vc, unsigned int nr)
> {
> unsigned short *p = (unsigned short *) vc->vc_pos;
>
> - scr_memcpyw(p, p + nr, vc->vc_cols - vc->vc_x - nr);
> + scr_memcpyw(p, p + nr, (vc->vc_cols - vc->vc_x - nr) * 2);
> scr_memsetw(p + vc->vc_cols - vc->vc_x - nr, vc->vc_video_erase_char,
> nr * 2);
> vc->vc_need_wrap = 0;
> if (DO_UPDATE(vc))
> do_update_region(vc, (unsigned long) p,
> - (vc->vc_cols - vc->vc_x) / 2);
> + vc->vc_cols - vc->vc_x);
> }
>
> static int softcursor_original;
Tested-by: Krzysztof Mazur <krzysiek@podlesie.net>
Thanks,
Krzysiek
prev parent reply other threads:[~2012-11-20 15:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-18 11:05 Krzysztof Mazur
2012-11-19 11:38 ` Alan Cox
2012-11-19 19:21 ` Jean-Francois Moine
2012-11-19 21:15 ` Krzysztof Mazur
2012-11-20 8:54 ` Jean-Francois Moine
2012-11-20 15:20 ` Krzysztof Mazur [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121120152055.GA5684@shrek.podlesie.net \
--to=krzysiek@podlesie.net \
--cc=alan@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=moinejf@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®