From: Thierry Reding <thierry.reding@avionic-design.de>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Tero Kristo <t-kristo@ti.com>,
Grazvydas Ignotas <notasas@gmail.com>,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v3 3/3] pwm: New driver to support PWM driven LEDs on TWL4030/6030 series of PMICs
Date: Fri, 23 Nov 2012 16:04:12 +0100 [thread overview]
Message-ID: <20121123150412.GB16810@avionic-0098.adnet.avionic-design.de> (raw)
In-Reply-To: <1353405382-9226-4-git-send-email-peter.ujfalusi@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1280 bytes --]
On Tue, Nov 20, 2012 at 10:56:22AM +0100, Peter Ujfalusi wrote:
> The driver supports the following LED outputs as generic PWM driver:
> TWL4030 LEDA and LEDB (PWMA and PWMB)
> TWL6030 Charging indicator LED (PWM LED)
>
> On TWL6030 when the PWM requested LED is configured to be controlled by SW.
> In this case the user can enable/disable and set the duty period freely.
> When the PWM has been freed, the LED driver is put back to HW control.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> drivers/pwm/Kconfig | 10 ++
> drivers/pwm/Makefile | 1 +
> drivers/pwm/pwm-twl-led.c | 303 ++++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 314 insertions(+)
> create mode 100644 drivers/pwm/pwm-twl-led.c
Doesn't this belong in the drivers/leds subsystem? Besides that, the
same comments as for the previous patch apply. One additional note
below.
> +static struct platform_driver twl_pwmled_driver = {
> + .driver = {
> + .name = "twl-pwmled",
> + .of_match_table = of_match_ptr(twl_pwmled_of_match),
> + },
> + .probe = twl_pwmled_probe,
> + .remove = __devexit_p(twl_pwmled_remove),
You didn't annotate twl_pwmled_remove() with __devexit, so __devexit_p
isn't needed here either.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-11-23 15:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-20 9:56 [PATCH v3 0/3] pwm: Drivers for twl4030/6030 PWMs and LEDs Peter Ujfalusi
2012-11-20 9:56 ` [PATCH v3 1/3] pwm: Remove pwm-twl6030 driver Peter Ujfalusi
2012-11-23 15:05 ` Thierry Reding
2012-11-26 9:11 ` Peter Ujfalusi
2012-11-20 9:56 ` [PATCH v3 2/3] pwm: New driver to support PWMs on TWL4030/6030 series of PMICs Peter Ujfalusi
2012-11-23 14:58 ` Thierry Reding
2012-11-26 9:31 ` Peter Ujfalusi
2012-11-20 9:56 ` [PATCH v3 3/3] pwm: New driver to support PWM driven LEDs " Peter Ujfalusi
2012-11-20 11:54 ` Peter Ujfalusi
2012-11-20 11:58 ` Thierry Reding
2012-11-23 9:51 ` Peter Ujfalusi
2012-11-23 15:04 ` Thierry Reding [this message]
2012-11-26 8:30 ` Peter Ujfalusi
2012-11-26 9:17 ` Thierry Reding
2012-11-26 9:33 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121123150412.GB16810@avionic-0098.adnet.avionic-design.de \
--to=thierry.reding@avionic-design.de \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=notasas@gmail.com \
--cc=peter.ujfalusi@ti.com \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®