From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Cox <alan@linux.intel.com>, Jamie Iles <jamie@jamieiles.com>,
linux-serial@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/5] serial: 8250_dw: Set FIFO size dynamically
Date: Wed, 28 Nov 2012 13:18:26 +0000 [thread overview]
Message-ID: <20121128131826.38391319@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <1354106924-11013-6-git-send-email-heikki.krogerus@linux.intel.com>
> + if (!reg || (reg & 0xff) != '*')
> + return;
> +
That looks bogus. If reg == 0 then reg & 0xFF != '*'
So why the double test ?
next prev parent reply other threads:[~2012-11-28 13:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-28 12:48 [PATCH 0/5] serial: 8250: 8250_dw changes and dynamic capabilities Heikki Krogerus
2012-11-28 12:48 ` [PATCH 1/5] serial: 8250: Allow drivers to deliver capabilities Heikki Krogerus
2012-11-28 12:48 ` [PATCH 2/5] serial: 8250_dw: Don't use UPF_FIXED_TYPE Heikki Krogerus
2012-11-28 12:48 ` [PATCH 3/5] serial: 8250_dw: Map IO memory Heikki Krogerus
2012-11-28 12:48 ` [PATCH 4/5] serial: 8250_dw: Move device tree code to separate function Heikki Krogerus
2012-11-28 12:48 ` [PATCH 5/5] serial: 8250_dw: Set FIFO size dynamically Heikki Krogerus
2012-11-28 13:18 ` Alan Cox [this message]
2012-11-28 13:37 ` Heikki Krogerus
2012-11-28 14:29 ` Heikki Krogerus
2012-11-30 13:48 ` [PATCH 0/5] serial: 8250: 8250_dw changes and dynamic capabilities Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121128131826.38391319@pyramind.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=alan@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jamie@jamieiles.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®