From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Oskar Schirmer <oskar@scara.com>
Cc: Wolfram Sang <w.sang@pengutronix.de>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Liam Girdwood <lrg@ti.com>,
Fabio Estevam <fabio.estevam@freescale.com>,
Zeng Zhaoming <zengzm.kernel@gmail.com>,
alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH] sound/sgtl5000: fix initial setting for DAC data source
Date: Wed, 28 Nov 2012 13:59:54 +0000 [thread overview]
Message-ID: <20121128135953.GA22582@sirena.org.uk> (raw)
In-Reply-To: <1354097668-3780-1-git-send-email-oskar@scara.com>
On Wed, Nov 28, 2012 at 10:14:28AM +0000, Oskar Schirmer wrote:
You've somehow decided to CC half the world but still haven't managed
to CC the maintainers like Liam asked (and as is covered in
SubmittingPatches)...
> According to documentation bit 3:2 in register SSS_CTRL are
> reserved and zero, so the setting of 0x0008 does not make much sense.
> Instead, bit 4 should be set as is with power up, to reflect
> routing of I2S_IN to DAC correctly.
> Looks much like an off by one error.
What does "as is with power up" mean? This is a register defaults
table, it should reflect what is in the register defaults. The meaning
of the field and the desired configuration for runtime is not relevant
here, the only thing that matters is what the default value of the
register is.
prev parent reply other threads:[~2012-11-28 14:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-28 9:20 Oskar Schirmer
2012-11-28 9:58 ` Liam Girdwood
2012-11-28 10:14 ` Oskar Schirmer
2012-11-28 13:59 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121128135953.GA22582@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=akpm@linux-foundation.org \
--cc=alsa-devel@alsa-project.org \
--cc=fabio.estevam@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=oskar@scara.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
--cc=w.sang@pengutronix.de \
--cc=zengzm.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®