mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hans Verkuil <hverkuil@xs4all.nl>
To: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	devel@driverdev.osuosl.org,
	DLOS <davinci-linux-open-source@linux.davincidsp.com>,
	Mauro Carvalho Chehab <mchehab@redhat.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Prabhakar Lad <prabhakar.lad@ti.com>,
	Hans Verkuil <hansverk@cisco.com>,
	Prabhakar Lad <prabhakar.csengg@gmail.com>,
	Sakari Ailus <sakari.ailus@iki.fi>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Hans Verkuil <hans.verkuil@cisco.com>,
	Manjunath Hadli <manjunath.hadli@ti.com>,
	LMML <linux-media@vger.kernel.org>
Subject: Re: [PATCH v3 0/9] Media Controller capture driver for DM365
Date: Thu, 29 Nov 2012 08:40:40 +0100	[thread overview]
Message-ID: <201211290840.40670.hverkuil@xs4all.nl> (raw)
In-Reply-To: <50B6A29D.9050004@gmail.com>

On Thu November 29 2012 00:47:41 Sylwester Nawrocki wrote:
> On 11/28/2012 10:29 PM, Dan Carpenter wrote:
> > On Wed, Nov 28, 2012 at 08:30:04PM +0100, Sylwester Nawrocki wrote:
> >> On 11/28/2012 01:22 PM, Dan Carpenter wrote:
> >>> In the end this is just a driver, and I don't especially care.  But
> >>> it's like not just this one which makes me frustrated.  I really
> >>> believe in linux-next and I think everything should spend a couple
> >>> weeks there before being merged.
> >>
> >> Couple of weeks in linux-next plus a couple of weeks of final patch
> >> series version awaiting to being reviewed and picked up by a maintainer
> >> makes almost entire kernel development cycle. These are huge additional
> >> delays, especially in the embedded world. Things like these certainly
> >> aren't encouraging for moving over from out-of-tree to the mainline
> >> development process. And in this case we are talking only about merging
> >> driver to the staging tree...
> >
> > Yeah.  A couple weeks is probably too long.  But I think a week is
> > totally reasonable.
> 
> Agreed, exactly that couple weeks requirement seemed a bit long to me.
> 
> > You have the process wrong.  The maintainer reviews it first, merges
> > it into his -next git tree.  It sits in linux-next for a bit.  The
> > merge window opens up.  It is merged.  It gets tested for 3 months.
> > It is released.
> 
> I believe what you're describing is true for most subsystems.  At
> linux-media the process looks roughly that you prepare a patch and post
> it to the mailing list for review.  Regular developers review it, you
> address the comments and submit again.  Repeat these steps until
> everyone's happy.  Then, when the patch looks like it is ready for
> merging it is preferred to send the maintainer a pull request.
> Now there can be a delay of up to couple weeks.  Afterwards the patch
> in most cases gets merged, with a few possible change requests. However
> it may happen the maintainer has different views on what's has been
> agreed before and you start everything again.

Yes, and the problem is that the maintainer (Mauro) tends to look at this
close to the merge window, generally leaving you with very little time to
make adjustments.

In all honesty, in this particular case the pull request came in late
because other reviewers asked TI to move the driver to staging because we
thought the driver wasn't quite ready yet.

If it would just be merged as a staging driver, then it would most likely
be sitting in linux-next by now since a few days, well in time for the merge
window. Instead we are having this whole discussion :-(

> With a few sub-maintainers recently appointed hopefully there can be
> seen some improvement.

I sincerely hope so. Of course, since I'm going to be one of the sub-maintainers
I'm going to see this from the other side as well, so I might get the same
critisism in the future :-)

> > It should work as a continuous even flow.  It shouldn't be a rush to
> > submit drivers right before the merge window opens.  It's not hard,
> > you can submit a driver to linux-next at any time.  It magically
> > flows through the process and is released some months later.
> >
> > It does suck to add a 3 month delay for people who miss the cut off.
> > Don't wait until the last minute.  In the embedded world you can
> > use git cherry-pick to get the driver from linux-next.
> 
> Yeah, it's not unusual to work with specific -rc tree with multiple
> subsystem -next branches on top of it.
> 
> It's just those cases where you're told to get feature A in the kernel
> release X and it is already late in the development cycle... But it
> might just be a matter of planning the work adequately with proper
> understanding of the whole process.

Well, it would work if you can rely on patches being reviewed and merged
in a timely manner. Hopefully that will happen when the sub-maintainers
can start next year. It should make everything more predictable.

Regards,

	Hans

  reply	other threads:[~2012-11-29  7:42 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-28 10:42 Prabhakar Lad
2012-11-28 10:42 ` [PATCH v3 1/9] davinci: vpfe: add v4l2 capture driver with media interface Prabhakar Lad
2012-11-28 10:42 ` [PATCH v3 2/9] davinci: vpfe: add v4l2 video driver support Prabhakar Lad
2012-11-28 10:42 ` [PATCH v3 3/9] davinci: vpfe: dm365: add IPIPEIF driver based on media framework Prabhakar Lad
2012-11-28 10:42 ` [PATCH v3 4/9] davinci: vpfe: dm365: add ISIF " Prabhakar Lad
2012-11-28 10:42 ` [PATCH v3 5/9] davinci: vpfe: dm365: add IPIPE support for media controller driver Prabhakar Lad
2012-11-28 10:42 ` [PATCH v3 6/9] davinci: vpfe: dm365: add IPIPE hardware layer support Prabhakar Lad
2012-11-28 10:42 ` [PATCH v3 7/9] davinci: vpfe: dm365: resizer driver based on media framework Prabhakar Lad
2012-11-28 10:42 ` [PATCH v3 8/9] davinci: vpfe: dm365: add build infrastructure for capture driver Prabhakar Lad
2012-11-28 10:42 ` [PATCH v3 9/9] davinci: vpfe: Add documentation and TODO Prabhakar Lad
2012-11-28 11:22   ` Mauro Carvalho Chehab
2012-11-28 13:00     ` Laurent Pinchart
2012-11-28 19:35       ` Mauro Carvalho Chehab
2012-11-29  3:08         ` Prabhakar Lad
2012-11-28 20:00     ` Sakari Ailus
2012-11-28 11:45 ` [PATCH v3 0/9] Media Controller capture driver for DM365 Dan Carpenter
2012-11-28 11:56   ` Hans Verkuil
2012-11-28 12:18     ` Mauro Carvalho Chehab
2012-11-28 17:22       ` Greg Kroah-Hartman
2012-11-28 19:18         ` Hans Verkuil
2012-11-28 19:30           ` Greg Kroah-Hartman
2012-11-29  7:43             ` Hans Verkuil
2012-11-29 10:39               ` Mauro Carvalho Chehab
2012-11-29 12:45                 ` Manjunath Hadli
2012-11-29 16:38                   ` Mauro Carvalho Chehab
2012-11-28 21:04           ` Dan Carpenter
2012-11-28 12:22     ` Dan Carpenter
2012-11-28 19:30       ` Sylwester Nawrocki
2012-11-28 20:46         ` Greg Kroah-Hartman
2012-11-28 21:29         ` Dan Carpenter
2012-11-28 23:47           ` Sylwester Nawrocki
2012-11-29  7:40             ` Hans Verkuil [this message]
2012-11-28 20:04     ` Sakari Ailus
2012-11-29 10:12 ` Laurent Pinchart
2012-11-30  9:47 ` Sakari Ailus
2012-11-30  9:54   ` Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201211290840.40670.hverkuil@xs4all.nl \
    --to=hverkuil@xs4all.nl \
    --cc=dan.carpenter@oracle.com \
    --cc=davinci-linux-open-source@linux.davincidsp.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hans.verkuil@cisco.com \
    --cc=hansverk@cisco.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=manjunath.hadli@ti.com \
    --cc=mchehab@redhat.com \
    --cc=prabhakar.csengg@gmail.com \
    --cc=prabhakar.lad@ti.com \
    --cc=s.nawrocki@samsung.com \
    --cc=sakari.ailus@iki.fi \
    --cc=sylvester.nawrocki@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®