From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Chao Xie <chao.xie@marvell.com>
Cc: a.zummo@towertech.it, rtc-linux@googlegroups.com,
linux-kernel@vger.kernel.org, haojian.zhuang@gmail.com,
linux-arm-kernel@lists.infradead.org, xiechao.mail@gmail.com
Subject: Re: [PATCH 4/4] rtc: pxa: request rtc irqs when probe/remove the device
Date: Thu, 29 Nov 2012 10:26:31 +0000 [thread overview]
Message-ID: <20121129102631.GH19440@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1354155670-6267-4-git-send-email-chao.xie@marvell.com>
On Wed, Nov 28, 2012 at 09:21:10PM -0500, Chao Xie wrote:
> The original pxa_rtc_open/pxa_rtc_release will be called
> when the /dev/rtc0 is opened or closed.
> In fact, these two functions will register/unregister the irqs.
> User application will use /dev/rtc0 to read the rtc time or set
> the alarm. The rtc should still run indepent of open/close the
> rtc device.
> So only register the irqs when probe the device,
> and disable clock and unregister the irqs when remove the device.
Again, this is wrong.
next prev parent reply other threads:[~2012-11-29 10:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 2:21 [PATCH 1/4] rtc: sa1100: enable/disable rtc " Chao Xie
2012-11-29 2:21 ` [PATCH 2/4] rtc: pxa: fix rtc caculation issue Chao Xie
2012-11-29 20:04 ` Robert Jarzmik
2012-12-03 2:40 ` Chao Xie
2012-12-04 2:53 ` Chao Xie
2012-11-29 2:21 ` [PATCH 3/4] rtc: pxa: add pxa95x rtc support Chao Xie
2012-12-04 7:03 ` Haojian Zhuang
2012-11-29 2:21 ` [PATCH 4/4] rtc: pxa: request rtc irqs when probe/remove the device Chao Xie
2012-11-29 10:26 ` Russell King - ARM Linux [this message]
2012-11-29 20:10 ` Robert Jarzmik
2012-11-29 10:25 ` [PATCH 1/4] rtc: sa1100: enable/disable rtc " Russell King - ARM Linux
2012-11-30 7:04 ` Haojian Zhuang
2012-12-03 1:39 ` Chao Xie
2012-12-03 2:53 ` Chao Xie
2012-12-03 5:35 ` Haojian Zhuang
2012-12-03 5:42 ` Chao Xie
2012-12-03 9:48 ` Russell King - ARM Linux
2012-12-04 2:51 ` Chao Xie
2012-12-04 7:01 ` Haojian Zhuang
2012-12-03 5:33 ` Haojian Zhuang
2012-12-03 5:02 ` devendra.aaru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121129102631.GH19440@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=a.zummo@towertech.it \
--cc=chao.xie@marvell.com \
--cc=haojian.zhuang@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=xiechao.mail@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®