From: Marcelo Tosatti <mtosatti@redhat.com>
To: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
Cc: Avi Kivity <avi@redhat.com>, Gleb Natapov <gleb@redhat.com>,
LKML <linux-kernel@vger.kernel.org>, KVM <kvm@vger.kernel.org>
Subject: Re: [PATCH 2/2] KVM: VMX: fix memory order between loading vmcs and clearing vmcs
Date: Thu, 29 Nov 2012 21:15:39 -0200 [thread overview]
Message-ID: <20121129231539.GA7409@amt.cnet> (raw)
In-Reply-To: <50B60976.7020905@linux.vnet.ibm.com>
On Wed, Nov 28, 2012 at 08:54:14PM +0800, Xiao Guangrong wrote:
> vmcs->cpu indicates whether it exists on the target cpu, -1 means the vmcs
> does not exist on any vcpu
>
> If vcpu load vmcs with vmcs.cpu = -1, it can be directly added to cpu's percpu
> list. The list can be corrupted if the cpu prefetch the vmcs's list before
> reading vmcs->cpu. Meanwhile, we should remove vmcs from the list before
> making vmcs->vcpu == -1 be visible
>
> Signed-off-by: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
> ---
> arch/x86/kvm/vmx.c | 17 +++++++++++++++++
> 1 files changed, 17 insertions(+), 0 deletions(-)
Applied, thanks.
next prev parent reply other threads:[~2012-11-30 20:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-28 12:53 [PATCH 1/2] KVM: VMX: fix invalid cpu passed to smp_call_function_single Xiao Guangrong
2012-11-28 12:54 ` [PATCH 2/2] KVM: VMX: fix memory order between loading vmcs and clearing vmcs Xiao Guangrong
2012-11-29 0:04 ` Marcelo Tosatti
2012-11-29 2:04 ` Xiao Guangrong
2012-11-29 3:06 ` Xiao Guangrong
2012-11-29 23:15 ` Marcelo Tosatti [this message]
2012-11-29 0:06 ` [PATCH 1/2] KVM: VMX: fix invalid cpu passed to smp_call_function_single Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121129231539.GA7409@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xiaoguangrong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®