From: Tejun Heo <tj@kernel.org>
To: Gao feng <gaofeng@cn.fujitsu.com>
Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
containers@lists.linux-foundation.org, lizefan@huawei.com
Subject: Re: [PATCH RESEND] cgroup: remove subsystem files when remounting cgroup
Date: Mon, 3 Dec 2012 08:34:23 -0800 [thread overview]
Message-ID: <20121203163423.GC19802@htj.dyndns.org> (raw)
In-Reply-To: <1354498098-17312-1-git-send-email-gaofeng@cn.fujitsu.com>
On Mon, Dec 03, 2012 at 09:28:18AM +0800, Gao feng wrote:
> cgroup_clear_directroy is called by cgroup_d_remove_dir
> and cgroup_remount.
>
> when we call cgroup_remount to remount the cgroup,the subsystem
> may be unlinked from cgroupfs_root->subsys_list in rebind_subsystem,this
> subsystem's files will not be removed in cgroup_clear_directroy.
> And the system will panic when we try to access these files.
>
> this patch removes subsystems's files before rebind_subsystems,
> if rebind_subsystems failed, repopulate these removed files.
>
> With help from Tejun.
>
> Signed-off-by: Gao feng <gaofeng@cn.fujitsu.com>
Applied to cgroup/for-3.8 with spaces added after commas.
Thanks!
--
tejun
next prev parent reply other threads:[~2012-12-03 16:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-30 16:21 [PATCH 1/2] cgroup: use cgroup_addrm_files in cgroup_clear_directory Gao feng
2012-11-30 16:21 ` [PATCH 2/2] cgroup: remove subsystem files when remounting cgroup Gao feng
2012-11-30 19:27 ` Tejun Heo
2012-12-03 0:45 ` Gao feng
2012-12-03 1:28 ` [PATCH RESEND] " Gao feng
2012-12-03 16:34 ` Tejun Heo [this message]
2012-11-30 19:47 ` [PATCH] cgroup: use cgroup_addrm_files() in cgroup_clear_directory() Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121203163423.GC19802@htj.dyndns.org \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=containers@lists.linux-foundation.org \
--cc=gaofeng@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome