From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752801Ab2LEMSs (ORCPT ); Wed, 5 Dec 2012 07:18:48 -0500 Received: from ams-iport-3.cisco.com ([144.254.224.146]:11472 "EHLO ams-iport-3.cisco.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751587Ab2LEMSr (ORCPT ); Wed, 5 Dec 2012 07:18:47 -0500 X-Greylist: delayed 588 seconds by postgrey-1.27 at vger.kernel.org; Wed, 05 Dec 2012 07:18:46 EST X-IronPort-AV: E=McAfee;i="5400,1158,6916"; a="10162919" From: Hans Verkuil To: Prabhakar Lad Subject: Re: [PATCH RFC v2] media: v4l2-ctrl: Add gain controls Date: Wed, 5 Dec 2012 13:08:34 +0100 User-Agent: KMail/1.13.7 (Linux/3.6-7.slh.1-aptosid-amd64; KDE/4.8.4; x86_64; ; ) Cc: LMML , LKML , LDOC , Sakari Ailus , Laurent Pinchart , Kyungmin Park , Guennadi Liakhovetski , Sylwester Nawrocki , Hans Verkuil , Hans de Goede , Chris MacGregor , Rob Landley , Jeongtae Park , Mauro Carvalho Chehab References: <1354708169-1139-1-git-send-email-prabhakar.csengg@gmail.com> In-Reply-To: <1354708169-1139-1-git-send-email-prabhakar.csengg@gmail.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201212051308.34309.hverkuil@xs4all.nl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (resend without HTML formatting) On Wed 5 December 2012 12:49:29 Prabhakar Lad wrote: > From: Lad, Prabhakar > > add support for per color component digital/analog gain controls > and also their corresponding offset. Some obvious questions below... > > Signed-off-by: Lad, Prabhakar > Cc: Sakari Ailus > Cc: Laurent Pinchart > Cc: Kyungmin Park > Cc: Guennadi Liakhovetski > Cc: Sylwester Nawrocki > Cc: Hans Verkuil > Cc: Hans de Goede > Cc: Chris MacGregor > Cc: Rob Landley > Cc: Jeongtae Park > Cc: Mauro Carvalho Chehab > --- > Changes for v2: > 1: Fixed review comments pointed by Laurent. > 2: Rebased on latest tree. > > Documentation/DocBook/media/v4l/controls.xml | 54 ++++++++++++++++++++++++++ > drivers/media/v4l2-core/v4l2-ctrls.c | 11 +++++ > include/uapi/linux/v4l2-controls.h | 11 +++++ > 3 files changed, 76 insertions(+), 0 deletions(-) > > diff --git a/Documentation/DocBook/media/v4l/controls.xml b/Documentation/DocBook/media/v4l/controls.xml > index 7fe5be1..847a9bb 100644 > --- a/Documentation/DocBook/media/v4l/controls.xml > +++ b/Documentation/DocBook/media/v4l/controls.xml > @@ -4543,6 +4543,60 @@ interface and may change in the future. > specific test patterns can be used to test if a device is working > properly. > > + > + V4L2_CID_GAIN_RED > + integer > + > + > + V4L2_CID_GAIN_GREEN_RED > + integer > + > + > + V4L2_CID_GAIN_GREEN_BLUE > + integer > + > + > + V4L2_CID_GAIN_BLUE > + integer > + > + > + V4L2_CID_GAIN_GREEN > + integer > + > + > + Some capture/sensor devices have > + the capability to set per color component digital/analog gain values. > + > + > + V4L2_CID_GAIN_OFFSET > + integer > + > + > + V4L2_CID_BLUE_OFFSET > + integer > + > + > + V4L2_CID_RED_OFFSET > + integer > + > + > + V4L2_CID_GREEN_OFFSET > + integer > + > + > + V4L2_CID_GREEN_RED_OFFSET > + integer > + > + > + V4L2_CID_GREEN_BLUE_OFFSET > + integer > + > + > + Some capture/sensor devices have the > + capability to set per color component digital/analog gain offset values. > + V4L2_CID_GAIN_OFFSET is the global gain offset and the rest are per > + color component gain offsets. If I set both V4L2_CID_GAIN_RED and V4L2_CID_RED_OFFSET, how are they supposed to interact? Or are they mutually exclusive? And if I set both V4L2_CID_GAIN_OFFSET and V4L2_CID_RED_OFFSET, how are they supposed to interact? This questions should be answered in the documentation... Regards, Hans > + > > > > diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b/drivers/media/v4l2-core/v4l2-ctrls.c > index f6ee201..05e3708 100644 > --- a/drivers/media/v4l2-core/v4l2-ctrls.c > +++ b/drivers/media/v4l2-core/v4l2-ctrls.c > @@ -790,6 +790,17 @@ const char *v4l2_ctrl_get_name(u32 id) > case V4L2_CID_LINK_FREQ: return "Link Frequency"; > case V4L2_CID_PIXEL_RATE: return "Pixel Rate"; > case V4L2_CID_TEST_PATTERN: return "Test Pattern"; > + case V4L2_CID_GAIN_RED: return "Gain Red"; > + case V4L2_CID_GAIN_GREEN_RED: return "Gain Green Red"; > + case V4L2_CID_GAIN_GREEN_BLUE: return "Gain Green Blue"; > + case V4L2_CID_GAIN_BLUE: return "Gain Blue"; > + case V4L2_CID_GAIN_GREEN: return "Gain Green"; > + case V4L2_CID_GAIN_OFFSET: return "Gain Offset"; > + case V4L2_CID_BLUE_OFFSET: return "Gain Blue Offset"; > + case V4L2_CID_RED_OFFSET: return "Gain Red Offset"; > + case V4L2_CID_GREEN_OFFSET: return "Gain Green Offset"; > + case V4L2_CID_GREEN_RED_OFFSET: return "Gain Green Red Offset"; > + case V4L2_CID_GREEN_BLUE_OFFSET: return "Gain Green Blue Offset"; > > /* DV controls */ > case V4L2_CID_DV_CLASS: return "Digital Video Controls"; > diff --git a/include/uapi/linux/v4l2-controls.h b/include/uapi/linux/v4l2-controls.h > index f56c945..9b6b233 100644 > --- a/include/uapi/linux/v4l2-controls.h > +++ b/include/uapi/linux/v4l2-controls.h > @@ -799,5 +799,16 @@ enum v4l2_jpeg_chroma_subsampling { > #define V4L2_CID_LINK_FREQ (V4L2_CID_IMAGE_PROC_CLASS_BASE + 1) > #define V4L2_CID_PIXEL_RATE (V4L2_CID_IMAGE_PROC_CLASS_BASE + 2) > #define V4L2_CID_TEST_PATTERN (V4L2_CID_IMAGE_PROC_CLASS_BASE + 3) > +#define V4L2_CID_GAIN_RED (V4L2_CID_IMAGE_PROC_CLASS_BASE + 4) > +#define V4L2_CID_GAIN_GREEN_RED (V4L2_CID_IMAGE_PROC_CLASS_BASE + 5) > +#define V4L2_CID_GAIN_GREEN_BLUE (V4L2_CID_IMAGE_PROC_CLASS_BASE + 6) > +#define V4L2_CID_GAIN_BLUE (V4L2_CID_IMAGE_PROC_CLASS_BASE + 7) > +#define V4L2_CID_GAIN_GREEN (V4L2_CID_IMAGE_PROC_CLASS_BASE + 8) > +#define V4L2_CID_GAIN_OFFSET (V4L2_CID_IMAGE_PROC_CLASS_BASE + 9) > +#define V4L2_CID_BLUE_OFFSET (V4L2_CID_IMAGE_PROC_CLASS_BASE + 10) > +#define V4L2_CID_RED_OFFSET (V4L2_CID_IMAGE_PROC_CLASS_BASE + 11) > +#define V4L2_CID_GREEN_OFFSET (V4L2_CID_IMAGE_PROC_CLASS_BASE + 12) > +#define V4L2_CID_GREEN_RED_OFFSET (V4L2_CID_IMAGE_PROC_CLASS_BASE + 13) > +#define V4L2_CID_GREEN_BLUE_OFFSET (V4L2_CID_IMAGE_PROC_CLASS_BASE + 14) > > #endif >