mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Myron Stowe <myron.stowe@redhat.com>
To: bhelgaas@google.com
Cc: linux-pci@vger.kernel.org, yinghai@kernel.org,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 00/15] PCI/ACPI: Remove "pci_root" sub-driver support
Date: Thu, 06 Dec 2012 23:24:54 -0700	[thread overview]
Message-ID: <20121207062454.11051.12739.stgit@amt.stowe> (raw)

The "PCI Root Bridge ("pci_root")" driver includes support for attaching
sub-drivers.  acpi_pci_register_driver() and acpi_pci_unregister_driver()
are the interfaces that sub-drivers use to attach themselves.

Currently there are only two callers of acpi_pci_register_driver(): the
"ACPI Hot Plug PCI Controller Driver ("acpiphp")" and "ACPI PCI Slot
Detection Driver ("pci_slot")" sub-drivers.

Sub-drivers may be compiled as modules.  Kernel modules are instantiated
somewhat randomly - the order in which they are linked as the kernel as
built - thus if there are any dependencies on the ordering of attaching
sub-drivers, they can not be effectively dealt with.

This patch series resolves any potential sequencing inter-dependencies by
converting sub-driver functionality to being only supported as statically
built-in to the kernel as part of the "pci_root" driver itself (i.e. no
longer supported as a module).  Inter-dependencies can then be effectively
handled by explicitly sequencing the addition of such functionality.


The series begins with a patch from Yinghai Lu's "PCI, ACPI, x86: pci root
bus hotplug support" series that separates host bridge specific hot-plug
functionality from PCI device hot-plug functionality.  This patch
significantly simplifies a fairly confusing implementation due to the
co-mingling that currently exists.
  Reference: https://lkml.org/lkml/2012/9/19/413

The rest of the patches in this series implement the conversion of the
"PCI Root Bridge" sub-drivers.  This also simplifies the implementation as
is revealed by a 'diffstat' of the respective, conversion related,
patches: 9 files changed, 86 insertions(+), 237 deletions(-)


This series is targeting the 3.9 merge window.  I expect that after
3.8-rc1 is released, a -v2 of this series will be required due to Bill
Pemberton's "[PATCH 000/493] remove CONFIG_HOTPLUG as an option" series.
That said, I wanted to go ahead and get this out now in order to solicit
feedback.
  Reference: https://lkml.org/lkml/2012/11/16/660
---

Myron Stowe (14):
      PCI/ACPI: Remove the "pci_root" driver's sub-driver infrastructure
      PCI/ACPI: Add "pci_slot" functionality statically within "pci_root"
      PCI/ACPI: Convert "pci_slot" sub-driver's functionality to built-in only
      PCI/ACPI: Move where dmi_check_system() is called from
      PCI/ACPI: Fix latent refcount issue in acpi_pci_root_start()
      PCI/acpiphp: Change acpiphp_add_bridge() to return void instead of 0
      PCI/acpiphp: Add "acpiphp" functionality statically within "pci_root"
      PCI/acpiphp: Collapse the initialization call chain of "acpiphp" further
      PCI/acpiphp: Declare acpi_{add,remove}_bridge() as external functions
      PCI/acpiphp: Convert "acpiphp" sub-driver's functionality to built-in only
      PCI/acpiphp: Collapse initialization call chain of "acpiphp" sub-driver
      PCI/acpiphp: Change acpiphp_glue_init() to return void instead of 0
      PCI/acpiphp: Leave the "acpiphp" sub-driver registered and in place
      PCI/acpiphp: Fix coding style of external declarations in acpiphp.h

Yinghai Lu (1):
      PCI, acpiphp: Separate out hot-add support of pci host bridge


 drivers/acpi/Kconfig               |    5 -
 drivers/acpi/Makefile              |    1 
 drivers/acpi/pci_root.c            |   50 +-------
 drivers/acpi/pci_root_hp.c         |  228 ++++++++++++++++++++++++++++++++++++
 drivers/acpi/pci_slot.c            |   84 +++++--------
 drivers/pci/hotplug/Kconfig        |    5 -
 drivers/pci/hotplug/acpiphp.h      |   17 +--
 drivers/pci/hotplug/acpiphp_core.c |   45 -------
 drivers/pci/hotplug/acpiphp_glue.c |  115 +++---------------
 include/linux/acpi.h               |    9 -
 include/linux/pci-acpi.h           |   16 +++
 11 files changed, 312 insertions(+), 263 deletions(-)
 create mode 100644 drivers/acpi/pci_root_hp.c

-- 

             reply	other threads:[~2012-12-07  6:25 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-07  6:24 Myron Stowe [this message]
2012-12-07  6:25 ` [PATCH 01/15] PCI, acpiphp: Separate out hot-add support of pci host bridge Myron Stowe
2012-12-07 19:32   ` Bjorn Helgaas
2012-12-07 21:04     ` Rafael J. Wysocki
2012-12-07 21:30     ` Yinghai Lu
2012-12-07 21:36       ` Bjorn Helgaas
2012-12-07 21:42         ` Yinghai Lu
2012-12-07  6:25 ` [PATCH 02/15] PCI/acpiphp: Fix coding style of external declarations in acpiphp.h Myron Stowe
2012-12-07  6:25 ` [PATCH 03/15] PCI/acpiphp: Leave the "acpiphp" sub-driver registered and in place Myron Stowe
2012-12-07  6:25 ` [PATCH 04/15] PCI/acpiphp: Change acpiphp_glue_init() to return void instead of 0 Myron Stowe
2012-12-07  6:25 ` [PATCH 05/15] PCI/acpiphp: Collapse initialization call chain of "acpiphp" sub-driver Myron Stowe
2012-12-07  6:25 ` [PATCH 06/15] PCI/acpiphp: Convert "acpiphp" sub-driver's functionality to built-in only Myron Stowe
2012-12-07  6:48   ` Yinghai Lu
2012-12-07 19:11     ` Myron Stowe
2012-12-07  6:25 ` [PATCH 07/15] PCI/acpiphp: Declare acpi_{add, remove}_bridge() as external functions Myron Stowe
2012-12-07  6:25 ` [PATCH 08/15] PCI/acpiphp: Collapse the initialization call chain of "acpiphp" further Myron Stowe
2012-12-07  6:25 ` [PATCH 09/15] PCI/acpiphp: Add "acpiphp" functionality statically within "pci_root" Myron Stowe
2012-12-07  6:25 ` [PATCH 10/15] PCI/acpiphp: Change acpiphp_add_bridge() to return void instead of 0 Myron Stowe
2012-12-07  6:25 ` [PATCH 11/15] PCI/ACPI: Fix latent refcount issue in acpi_pci_root_start() Myron Stowe
2012-12-07  6:26 ` [PATCH 12/15] PCI/ACPI: Move where dmi_check_system() is called from Myron Stowe
2012-12-07  6:26 ` [PATCH 13/15] PCI/ACPI: Convert "pci_slot" sub-driver's functionality to built-in only Myron Stowe
2012-12-07  6:26 ` [PATCH 14/15] PCI/ACPI: Add "pci_slot" functionality statically within "pci_root" Myron Stowe
2012-12-07  6:26 ` [PATCH 15/15] PCI/ACPI: Remove the "pci_root" driver's sub-driver infrastructure Myron Stowe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121207062454.11051.12739.stgit@amt.stowe \
    --to=myron.stowe@redhat.com \
    --cc=bhelgaas@google.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®