From: Michal Marek <mmarek@suse.cz>
To: pefoley2@verizon.net, David Howells <dhowells@redhat.com>,
Rusty Russell <rusty@rustcorp.com.au>
Cc: linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org
Subject: Re: [PATCH 2/5] kbuild: silence rule for extra_certificates
Date: Sun, 9 Dec 2012 17:54:25 +0100 [thread overview]
Message-ID: <20121209165425.GA29331@pobox.suse.cz> (raw)
In-Reply-To: <1353269117-39917-2-git-send-email-pefoley2@verizon.net>
Added David and Rusty.
On Sun, Nov 18, 2012 at 03:05:14PM -0500, pefoley2@verizon.net wrote:
> From: Peter Foley <pefoley2@verizon.net>
>
> Silence the touch extra_certificates command
>
> Signed-off-by: Peter Foley <pefoley2@verizon.net>
I think we should tell the user that the default empty extra
certificates list is being used, in case the user used a wrong filename
or similar. How about this?
Subject: MODSIGN: Fix kbuild output when using default extra_certificates
Signed-off-by: Michal Marek <mmarek@suse.cz>
diff --git a/kernel/Makefile b/kernel/Makefile
index 0dfeca4..8c708e4 100644
--- a/kernel/Makefile
+++ b/kernel/Makefile
@@ -136,8 +136,12 @@ ifeq ($(CONFIG_MODULE_SIG),y)
#
# Pull the signing certificate and any extra certificates into the kernel
#
+
+quiet_cmd_touch = TOUCH $@
+ cmd_touch = touch $@
+
extra_certificates:
- touch $@
+ $(call cmd,touch)
kernel/modsign_pubkey.o: signing_key.x509 extra_certificates
But I don't insist on the above, feel free to hide the command
completely.
Michal
> ---
> kernel/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/Makefile b/kernel/Makefile
> index 86e3285..18a0b61 100644
> --- a/kernel/Makefile
> +++ b/kernel/Makefile
> @@ -137,7 +137,7 @@ ifeq ($(CONFIG_MODULE_SIG),y)
> # Pull the signing certificate and any extra certificates into the kernel
> #
> extra_certificates:
> - touch $@
> + @touch $@
>
> kernel/modsign_pubkey.o: signing_key.x509 extra_certificates
>
> --
> 1.8.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-12-09 16:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-18 20:05 [PATCH 1/5] kbuild: remove deprecated use of defined in timeconst.pl pefoley2
2012-11-18 20:05 ` [PATCH 2/5] kbuild: silence rule for extra_certificates pefoley2
2012-12-09 16:54 ` Michal Marek [this message]
2012-12-10 0:08 ` Rusty Russell
2012-12-11 1:18 ` Peter Foley
2012-11-18 20:05 ` [PATCH 3/5] add eboot.o and efi_stub_$(BITS).o to $(targets) pefoley2
2012-12-09 16:35 ` Michal Marek
2012-11-18 20:05 ` [PATCH 4/5] silence 'arch/x86/realmode/rm/realmode.bin' is up to date message pefoley2
2012-12-09 16:37 ` Michal Marek
2012-11-18 20:05 ` [PATCH 5/5] x86: add dummy rules to avoid 'nothing to be done' messages pefoley2
2012-12-09 16:37 ` Michal Marek
2012-12-09 16:57 ` [PATCH 1/5] kbuild: remove deprecated use of defined in timeconst.pl Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121209165425.GA29331@pobox.suse.cz \
--to=mmarek@suse.cz \
--cc=dhowells@redhat.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pefoley2@verizon.net \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome