On Mon, Dec 10, 2012 at 02:06:49PM +0530, Abhilash Kesavan wrote: > On Mon, Dec 10, 2012 at 1:49 PM, Abhilash Kesavan > wrote: > > Mark Brown opensource.wolfsonmicro.com> writes: > >> Binding documenation is mandatory for any new OF properties, please add > >> this. > > Patch 3/3 of this series adds documentation for the max77686-opmode property. There is no point in splitting changes like this up, it just makes review harder - in this case it caused me to not read your patch due to the missing documentation. Put the whole change together unless things are getting too big to review.