From: Olaf Hering <olaf@aepfle.de>
To: Jan Beulich <JBeulich@suse.com>
Cc: konrad.wilk@oracle.com, xen-devel@lists.xen.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xen/blkback: prevent repeated backend_changed invocations
Date: Wed, 12 Dec 2012 10:47:49 +0100 [thread overview]
Message-ID: <20121212094749.GA3382@aepfle.de> (raw)
In-Reply-To: <50C85F9F02000078000AFD6E@nat28.tlf.novell.com>
On Wed, Dec 12, Jan Beulich wrote:
> >>> On 11.12.12 at 21:50, Olaf Hering <olaf@aepfle.de> wrote:
> > backend_changed might be called multiple times, which will leak
> > be->mode. Make sure it will be called only once. Remove some unneeded
> > checks. Also the be->mode string was leaked, release the memory on
> > device shutdown.
>
> So did I miss some discussion here? I haven't seen any
> confirmation of this function indeed being supposed to be called
> just once.
>
> Also, as said previously, if indeed it is to be called just once,
> removing the watch during/after the first invocation would seem
> to be the more appropriate thing to do.
Does the API allow this, that the called function can disable the watch?
Olaf
next prev parent reply other threads:[~2012-12-12 9:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-11 20:50 Olaf Hering
2012-12-12 9:42 ` Jan Beulich
2012-12-12 9:47 ` Olaf Hering [this message]
2012-12-12 9:53 ` Jan Beulich
2012-12-12 10:34 ` [Xen-devel] " Ian Campbell
2012-12-12 10:45 ` Olaf Hering
2012-12-13 15:02 ` Jan Beulich
2012-12-19 20:14 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121212094749.GA3382@aepfle.de \
--to=olaf@aepfle.de \
--cc=JBeulich@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome