From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Stephane Eranian <eranian@google.com>,
namhyung.kim@lge.com
Subject: Re: [PATCH 1/4] perf hists: Exchange order of comparing items when collapsing hists
Date: Wed, 12 Dec 2012 13:14:13 -0300 [thread overview]
Message-ID: <20121212161413.GB2382@ghostprotocols.net> (raw)
In-Reply-To: <20121212155632.GA1097@krava.brq.redhat.com>
Em Wed, Dec 12, 2012 at 04:56:32PM +0100, Jiri Olsa escreveu:
> On Wed, Dec 12, 2012 at 12:29:26PM -0300, Arnaldo Carvalho de Melo wrote:
> > Got inverted.
> > The order was arbitrary, and was arbitrarily reversed, are you guys sure this
> > is the only side effect?
> right,
> currently (without namhyung's changes) there's initial 'name' sorting
> broken by hists_link
> after the change, it gets sorted 'but' there are dummy entries added
> which brake the sort again.. this is sorted out within the multi diff
> patches
> so the bottom line is that currently the sorting is broken anyway,
> and the fix is comming in upcomming patchset ;)
Ok, applied to my perf/core branch and pushed out.
> > Jiri, IIRC you mentioned that there would be some patch with an --order switch,
> > would that allow sorting by the entry that had the biggest change, etc?
>
> by default it'll sorted by baseline and you can specify -o X to sort
> by specified file
great.
- Arnaldo
next prev parent reply other threads:[~2012-12-12 16:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-10 8:29 [PATCH 0/4] perf hists: Changes on hists__{match,link} (v4) Namhyung Kim
2012-12-10 8:29 ` [PATCH 1/4] perf hists: Exchange order of comparing items when collapsing hists Namhyung Kim
2012-12-10 13:44 ` Jiri Olsa
2012-12-12 15:29 ` Arnaldo Carvalho de Melo
2012-12-12 15:56 ` Jiri Olsa
2012-12-12 16:14 ` Arnaldo Carvalho de Melo [this message]
2013-01-25 10:47 ` [tip:perf/core] " tip-bot for Namhyung Kim
2012-12-10 8:29 ` [PATCH 2/4] perf hists: Link hist entries before inserting to an output tree Namhyung Kim
2013-01-25 10:48 ` [tip:perf/core] " tip-bot for Namhyung Kim
2012-12-10 8:29 ` [PATCH 3/4] perf diff: Use internal rb tree for compute resort Namhyung Kim
2013-01-25 10:49 ` [tip:perf/core] " tip-bot for Namhyung Kim
2012-12-10 8:29 ` [PATCH 4/4] perf test: Add a test case for hists__{match,link} Namhyung Kim
2013-01-25 10:51 ` [tip:perf/core] perf test: Add a test case for hists__{match, link} tip-bot for Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121212161413.GB2382@ghostprotocols.net \
--to=acme@ghostprotocols.net \
--cc=a.p.zijlstra@chello.nl \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome