From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754585Ab2LNKnV (ORCPT ); Fri, 14 Dec 2012 05:43:21 -0500 Received: from hqemgate03.nvidia.com ([216.228.121.140]:14599 "EHLO hqemgate03.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751319Ab2LNKnT (ORCPT ); Fri, 14 Dec 2012 05:43:19 -0500 X-PGP-Universal: processed; by hqnvupgp05.nvidia.com on Fri, 14 Dec 2012 02:43:12 -0800 Date: Fri, 14 Dec 2012 12:43:10 +0200 From: Peter De Schrijver To: Stephen Warren CC: Mike Turquette , Prashant Gaikwad , Stephen Warren , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH] clk: debug clock tree Message-ID: <20121214104310.GW19258@tbergstrom-lnx.Nvidia.com> References: <1355370586-6600-1-git-send-email-pgaikwad@nvidia.com> <50CA17FB.9060606@wwwdotorg.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <50CA17FB.9060606@wwwdotorg.org> X-NVConfidentiality: public User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 13, 2012 at 07:01:31PM +0100, Stephen Warren wrote: > On 12/13/2012 09:27 AM, Mike Turquette wrote: > > On Wed, Dec 12, 2012 at 7:49 PM, Prashant Gaikwad wrote: > >> Adds debug file "clock_tree" in /sys/kernel/debug/clk dir. > >> It helps to view all the clock registered in tree format. > >> > > > > Prashant, > > > > Thanks for submitting this. We've been talking about having a single > > file for representing the tree for some time. > > > > Regarding the output format had you considered using a well known > > format which can be parsed using well known parsing libs? This avoids > > needing a custom parser just for this one file. JSON springs to mind > > as something lightweight and well-understood. > > One advantage of the format below is that it's very easily > human-readable, and it's not too hard to parse (although I guess you'd > have to parse the indent level to get parent/child relation, which would > suck a bit). Is there room to provide both? Otherwise, I guess the > kernel could include a script to convert from JSON/whatever into the > format below. We already have the clk directory for an easy to parse version. So I think this one should be focused on being human readable. Cheers, Peter.