From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753130Ab2LQNwb (ORCPT ); Mon, 17 Dec 2012 08:52:31 -0500 Received: from mx1.redhat.com ([209.132.183.28]:64945 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752961Ab2LQNw3 (ORCPT ); Mon, 17 Dec 2012 08:52:29 -0500 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 Subject: [PATCH 1/2] keys: Fix unreachable code To: torvalds@linux-foundation.com From: David Howells Cc: linux-security-module@vger.kernel.org, Alan Cox , jmorris@namei.org, linux-kernel@vger.kernel.org Date: Mon, 17 Dec 2012 13:15:23 +0000 Message-ID: <20121217131523.2974.74337.stgit@warthog.procyon.org.uk> User-Agent: StGit/0.16 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alan Cox We set ret to NULL then test it. Remove the bogus test Signed-off-by: Alan Cox Signed-off-by: David Howells --- security/keys/process_keys.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/security/keys/process_keys.c b/security/keys/process_keys.c index 58dfe08..20e4bf5 100644 --- a/security/keys/process_keys.c +++ b/security/keys/process_keys.c @@ -367,8 +367,6 @@ key_ref_t search_my_process_keyrings(struct key_type *type, switch (PTR_ERR(key_ref)) { case -EAGAIN: /* no key */ - if (ret) - break; case -ENOKEY: /* negative key */ ret = key_ref; break;