From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Wang YanQing <udknight@gmail.com>
Cc: mmarek@suse.cz, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org, rdunlap@xenotime.net, bp@alien8.de,
sakiwit@gmail.com, lacombar@gmail.com,
lucas.demarchi@profusion.mobi, dave@gnu.org,
paul.gortmaker@windriver.com, crquan@gmail.com, bpoirier@suse.de
Subject: Re: [PATCH] kconfig:lxdialog: remove duplicate code
Date: Mon, 17 Dec 2012 19:19:07 +0100 [thread overview]
Message-ID: <201212171919.07368.yann.morin.1998@free.fr> (raw)
In-Reply-To: <20121217143751.GA16993@udknight>
Wang, All,
On Monday 17 December 2012 Wang YanQing wrote:
> dialog.h has two line the same below:
> extern char dialog_input_result[];
> This patch remove one of them.
>
> Signed-off-by: Wang YanQing <udknight@gmail.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Tested-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
> scripts/kconfig/lxdialog/dialog.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/scripts/kconfig/lxdialog/dialog.h b/scripts/kconfig/lxdialog/dialog.h
> index ee17a52..307022a 100644
> --- a/scripts/kconfig/lxdialog/dialog.h
> +++ b/scripts/kconfig/lxdialog/dialog.h
> @@ -221,7 +221,6 @@ int dialog_menu(const char *title, const char *prompt,
> const void *selected, int *s_scroll);
> int dialog_checklist(const char *title, const char *prompt, int height,
> int width, int list_height);
> -extern char dialog_input_result[];
> int dialog_inputbox(const char *title, const char *prompt, int height,
> int width, const char *init);
>
> --
> 1.7.11.1.116.g8228a23
>
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2012-12-17 18:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-17 14:37 Wang YanQing
2012-12-17 18:19 ` Yann E. MORIN [this message]
2012-12-24 4:48 ` Wang YanQing
2012-12-25 18:21 ` Yann E. MORIN
2012-12-26 0:09 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201212171919.07368.yann.morin.1998@free.fr \
--to=yann.morin.1998@free.fr \
--cc=bp@alien8.de \
--cc=bpoirier@suse.de \
--cc=crquan@gmail.com \
--cc=dave@gnu.org \
--cc=lacombar@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@profusion.mobi \
--cc=mmarek@suse.cz \
--cc=paul.gortmaker@windriver.com \
--cc=rdunlap@xenotime.net \
--cc=sakiwit@gmail.com \
--cc=udknight@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®