From: Jason Cooper <jason@lakedaemon.net>
To: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: Russell King <linux@arm.linux.org.uk>,
Andrew Lunn <andrew@lunn.ch>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] ARM: Dove: add Cubox sdhci card detect gpio
Date: Mon, 17 Dec 2012 20:37:08 -0500 [thread overview]
Message-ID: <20121218013708.GQ21694@titan.lakedaemon.net> (raw)
In-Reply-To: <50CFBDC4.8040109@gmail.com>
On Tue, Dec 18, 2012 at 01:50:12AM +0100, Sebastian Hesselbarth wrote:
> On 12/18/2012 01:38 AM, Jason Cooper wrote:
> > On Tue, Dec 18, 2012 at 01:24:29AM +0100, Sebastian Hesselbarth wrote:
> >> Card detect for sdhci on Cubox is connected to the wrong pin
> >> (sdio1_cd instead of sdio0_cd). With support for cd-gpios and
> >> pinctrl add the corresponding properties to DT for Cubox.
> >>
> >> Signed-off-by: Sebastian Hesselbarth<sebastian.hesselbarth@gmail.com>
> >> ...
> >> +&sdio0 {
> >> + status = "okay";
> >> + /* sdio0 card detect is connected to wrong pin on CuBox */
> >> + cd-gpios =<&gpio0 12 1>;
> >
> > this looks like a fix that should be merged into v3.8, I'll cue it up
> > for v3.8-rc2.
>
> Jason,
>
> it is more a feature than a fix, as gpio-cd support for sdhci-dove
> moved in lately. You want me to split this patch from the other two
> (that I'll reorder as requested)?
I was referring to the code more than the physical feature itself. You
appear to remove the default &sdio0, and replace it with a working
version. Looked like a fix to me ;-)
No need to send it separate, I'll apply it as is once v3.8-rc1 drops.
thx,
Jason.
next prev parent reply other threads:[~2012-12-18 1:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-18 0:24 [PATCH 1/3] ARM: Dove: split legacy and DT setup Sebastian Hesselbarth
2012-12-18 0:24 ` [PATCH 2/3] ARM: Dove: cleanup includes Sebastian Hesselbarth
2013-01-28 2:20 ` Jason Cooper
2012-12-18 0:24 ` [PATCH 3/3] ARM: Dove: add Cubox sdhci card detect gpio Sebastian Hesselbarth
2012-12-18 0:38 ` Jason Cooper
2012-12-18 0:50 ` Sebastian Hesselbarth
2012-12-18 1:37 ` Jason Cooper [this message]
2013-01-10 2:17 ` Jason Cooper
2012-12-18 0:35 ` [PATCH 1/3] ARM: Dove: split legacy and DT setup Jason Cooper
2013-01-28 2:19 ` Jason Cooper
2013-01-29 21:23 ` [PATCH v2 1/2] ARM: dove: cleanup includes Sebastian Hesselbarth
2013-01-29 21:23 ` [PATCH v2 2/2] ARM: dove: split legacy and DT setup Sebastian Hesselbarth
2013-01-29 21:26 ` Jason Cooper
2013-01-29 21:41 ` [PATCH v3 " Sebastian Hesselbarth
2013-01-31 0:52 ` Jason Cooper
2013-01-29 21:36 ` [PATCH v2 1/2] ARM: dove: cleanup includes Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121218013708.GQ21694@titan.lakedaemon.net \
--to=jason@lakedaemon.net \
--cc=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®