From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: linux-kbuild@vger.kernel.org
Cc: Wang YanQing <udknight@gmail.com>,
mmarek@suse.cz, linux-kernel@vger.kernel.org,
rdunlap@xenotime.net, bp@alien8.de, sakiwit@gmail.com,
lacombar@gmail.com, lucas.demarchi@profusion.mobi, dave@gnu.org,
paul.gortmaker@windriver.com, crquan@gmail.com, bpoirier@suse.de
Subject: Re: [PATCH 1/2 v2] menuconfig: Add Save/Load buttons
Date: Tue, 18 Dec 2012 19:42:37 +0100 [thread overview]
Message-ID: <201212181942.38037.yann.morin.1998@free.fr> (raw)
In-Reply-To: <20121218044021.GA7475@udknight>
Wang, All,
On Tuesday 18 December 2012 Wang YanQing wrote:
> If menuconfig have Save/Load button like alternative
> .config editors, xconfig, nconfig, etc.We will have
> a obvious benefit when use menuconfig just like
> when we use others, we can Save/Load our .config quickly
> and conveniently.
>
> This patch add the Save/Load button for menuconfig.
>
> [remove trailing space while at it for below line:
> "*) Formerly when I used Page Down and Page Up, the cursor would be set"
> ]
>
> Changes:
> V1-V2:
> 1:use PATH_MAX instead of hard code suggested by Yann E. MORIN
> 2:drop the spurious empty-line removal suggested by Yann E. MORIN
The "Changes" section should have been after the '---' mark, below, to
avoid it being in the commit log.
> Signed-off-by: Wang YanQing <udknight@gmail.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Tested-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
It works very well, and really mimicks the behavior we have in nconf! :-)
(But see a very minor comment below.)
> ---
> scripts/kconfig/lxdialog/menubox.c | 20 +++++++++++---------
> scripts/kconfig/mconf.c | 30 +++++++++++++++++++++++++-----
> 2 files changed, 36 insertions(+), 14 deletions(-)
>
> diff --git a/scripts/kconfig/lxdialog/menubox.c b/scripts/kconfig/lxdialog/menubox.c
> index 1d60473..8b534d5 100644
> --- a/scripts/kconfig/lxdialog/menubox.c
> +++ b/scripts/kconfig/lxdialog/menubox.c
[--SNIP--]
> @@ -154,12 +154,14 @@ static void print_arrows(WINDOW * win, int item_no, int scroll, int y, int x,
> */
> static void print_buttons(WINDOW * win, int height, int width, int selected)
> {
> - int x = width / 2 - 16;
> + int x = width / 2 - 26;
That's not well centered (sorry, I initially missed it), this should
have been '28':
( nb_buttons * button_size + (nb_buttons - 1) * button_separation ) / 2
( 5 * 8 + ( 5 - 1) * 4 ) / 2 = 28
But that's just eye-candy, and only is only obvious on very small terminals.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
prev parent reply other threads:[~2012-12-18 18:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-18 4:40 Wang YanQing
2012-12-18 18:42 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201212181942.38037.yann.morin.1998@free.fr \
--to=yann.morin.1998@free.fr \
--cc=bp@alien8.de \
--cc=bpoirier@suse.de \
--cc=crquan@gmail.com \
--cc=dave@gnu.org \
--cc=lacombar@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@profusion.mobi \
--cc=mmarek@suse.cz \
--cc=paul.gortmaker@windriver.com \
--cc=rdunlap@xenotime.net \
--cc=sakiwit@gmail.com \
--cc=udknight@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®