From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754963Ab2LRUcH (ORCPT ); Tue, 18 Dec 2012 15:32:07 -0500 Received: from mail.skyhub.de ([78.46.96.112]:43651 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754389Ab2LRUcD (ORCPT ); Tue, 18 Dec 2012 15:32:03 -0500 Date: Tue, 18 Dec 2012 21:31:59 +0100 From: Borislav Petkov To: Joe Perches Cc: Michal Marek , Cesar Eduardo Barros , linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, Andrew Morton , David Howells Subject: Re: [PATCH] scripts: add checkmaintainers.py Message-ID: <20121218203159.GI31255@liondog.tnic> Mail-Followup-To: Borislav Petkov , Joe Perches , Michal Marek , Cesar Eduardo Barros , linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, Andrew Morton , David Howells References: <1355523576-7596-1-git-send-email-cesarb@cesarb.net> <50CEF080.8010208@suse.cz> <20121217102714.GB31947@liondog.tnic> <1355758544.13361.14.camel@joe-AO722> <20121217170011.GC31866@liondog.tnic> <1355770579.13361.41.camel@joe-AO722> <1355771383.13361.44.camel@joe-AO722> <20121218182838.GF31255@liondog.tnic> <1355859281.30366.29.camel@joe-AO722> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1355859281.30366.29.camel@joe-AO722> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 18, 2012 at 11:34:41AM -0800, Joe Perches wrote: > If no patch is attached, you should get > > ERROR: Does not appear to be a unified-diff format patch Well, it needs to handle the case where a patch simply and only renames a file. Then, even if a patch follows: diff --git a/README b/README.old similarity index 99% rename from README rename to README.old index a24ec89ba442..b0a7aa56c3cc 100644 --- a/README +++ b/README.old @@ -1,3 +1,6 @@ +TEST + + Linux kernel release 3.x These are the release notes for Linux version 3. Read them carefully, -- it says: $ git diff --cached HEAD -- | ./scripts/checkpatch.pl --strict - Must be run from the top-level dir. of a kernel tree If I comment out the following hunk: if (!defined $root) { print "Must be run from the top-level dir. of a kernel tree\n"; exit(2); } then it works, albeit with a bunch of warnings: Use of uninitialized value $root in concatenation (.) or string at ./scripts/checkpatch.pl line 1558. Use of uninitialized value $root in concatenation (.) or string at ./scripts/checkpatch.pl line 1558. Use of uninitialized value $root in concatenation (.) or string at ./scripts/checkpatch.pl line 1304. Use of uninitialized value $root in concatenation (.) or string at ./scripts/checkpatch.pl line 1304. Use of uninitialized value $root in concatenation (.) or string at ./scripts/checkpatch.pl line 1304. Use of uninitialized value $root in concatenation (.) or string at ./scripts/checkpatch.pl line 1304. Use of uninitialized value $root in concatenation (.) or string at ./scripts/checkpatch.pl line 1304. Use of uninitialized value $root in concatenation (.) or string at ./scripts/checkpatch.pl line 1304. CHECK: Patch renames README to README.old, update MAINTAINERS? ... Looks like this would need a bit more work. Thanks. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. --