From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755382Ab2LRUrW (ORCPT ); Tue, 18 Dec 2012 15:47:22 -0500 Received: from mail.skyhub.de ([78.46.96.112]:58526 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754957Ab2LRUrU (ORCPT ); Tue, 18 Dec 2012 15:47:20 -0500 Date: Tue, 18 Dec 2012 21:47:16 +0100 From: Borislav Petkov To: Joe Perches Cc: Michal Marek , Cesar Eduardo Barros , linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, Andrew Morton , David Howells Subject: Re: [PATCH] scripts: add checkmaintainers.py Message-ID: <20121218204716.GJ31255@liondog.tnic> Mail-Followup-To: Borislav Petkov , Joe Perches , Michal Marek , Cesar Eduardo Barros , linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, Andrew Morton , David Howells References: <50CEF080.8010208@suse.cz> <20121217102714.GB31947@liondog.tnic> <1355758544.13361.14.camel@joe-AO722> <20121217170011.GC31866@liondog.tnic> <1355770579.13361.41.camel@joe-AO722> <1355771383.13361.44.camel@joe-AO722> <20121218182838.GF31255@liondog.tnic> <1355859281.30366.29.camel@joe-AO722> <20121218203159.GI31255@liondog.tnic> <1355862997.30366.36.camel@joe-AO722> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1355862997.30366.36.camel@joe-AO722> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 18, 2012 at 12:36:37PM -0800, Joe Perches wrote: > You renamed README which is one of the filenames used > when checkpatch verifies the top-level dir kernel tree. > > Don't do that, README is a required filename. $ git mv scripts/checkpatch{,-2}.pl $ git diff --cached HEAD -- | ./scripts/checkpatch-2.pl --strict - ERROR: Does not appear to be a unified-diff format patch total: 1 errors, 0 warnings, 0 checks, 0 lines checked Your patch has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. [ adjust .git/hooks/pre-commit to use the new ./scripts/checkpatch-2.pl script name] $ git commit -a scripts/checkpatch-2.pl:2685: space before tab in indent. + $ok = 1; scripts/checkpatch-2.pl:2691: space before tab in indent. + $ok = 1; No joy :( Let's try another file: $ git mv arch/x86/Kconfig{,.old} $ git diff --cached HEAD -- | ./scripts/checkpatch.pl --strict - ERROR: Does not appear to be a unified-diff format patch total: 1 errors, 0 warnings, 0 checks, 0 lines checked Your patch has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. $ git commit -a arch/x86/Kconfig.old:451: trailing whitespace. + Internet Device(MID) platform. Oh well, enough games for today. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. --