From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
To: axel.lin@ingics.com
Cc: akpm@linux-foundation.org, a.zummo@towertech.it,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtc: tx4939: Kill get_tx4939rtc_plat_data() function
Date: Wed, 19 Dec 2012 22:12:40 +0900 (JST) [thread overview]
Message-ID: <20121219.221240.129782578.anemo@mba.ocn.ne.jp> (raw)
In-Reply-To: <1355909344.11204.3.camel@phoenix>
On Wed, 19 Dec 2012 17:29:04 +0800, Axel Lin <axel.lin@ingics.com> wrote:
> Simply use dev_get_drvdata() instead.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/rtc/rtc-tx4939.c | 21 ++++++++-------------
> 1 file changed, 8 insertions(+), 13 deletions(-)
Hi Axel,
Thank you for cleanup, but, a platform driver should use
platform_get_drvdata / platform_set_drvdata, no?
I think using dev_get_drvdata() in platform_get_drvdata() is an
implementation detail of the platform device framework, so we should
not depends on such an internal detail.
If there was any reason to use dev_get_drvdata, please convert all
platform_get_drvdata and platform_set_drvdata to dev_get_drvdata and
dev_set_drvdata. We should avoid mixing two APIs.
---
Atsushi Nemoto
prev parent reply other threads:[~2012-12-19 13:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-19 9:29 Axel Lin
2012-12-19 13:12 ` Atsushi Nemoto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121219.221240.129782578.anemo@mba.ocn.ne.jp \
--to=anemo@mba.ocn.ne.jp \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=axel.lin@ingics.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®