From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755411Ab2LSUn3 (ORCPT ); Wed, 19 Dec 2012 15:43:29 -0500 Received: from charlotte.tuxdriver.com ([70.61.120.58]:39835 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755351Ab2LSUnX (ORCPT ); Wed, 19 Dec 2012 15:43:23 -0500 Date: Wed, 19 Dec 2012 15:42:38 -0500 From: Neil Horman To: Oleg Nesterov Cc: "Eric W. Biederman" , Pavel Emelyanov , Daniel Berrange , Alexander Viro , Serge Hallyn , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: + core_pattern-set-core-helpers-root-and-namespace-to-crashing-process .patch added to -mm tree Message-ID: <20121219204238.GA4390@hmsreliant.think-freely.org> References: <20121217123428.GA1957@redhat.com> <20121217150559.GD25322@hmsreliant.think-freely.org> <20121217160408.GA20166@redhat.com> <20121217183925.GE25322@hmsreliant.think-freely.org> <20121218200604.GA28834@redhat.com> <20121218201900.GA10059@hmsreliant.think-freely.org> <20121219162230.GA17514@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20121219162230.GA17514@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Score: -2.9 (--) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 19, 2012 at 05:22:30PM +0100, Oleg Nesterov wrote: > On 12/18, Neil Horman wrote: > > > > On Tue, Dec 18, 2012 at 09:06:04PM +0100, Oleg Nesterov wrote: > > > > Perhaps its best just to restrict this patch to adjusting the root fs location > > > > for the chroot case. > > > > > > Probably... at least for the start. > > > > > > BTW. Of course this is subjective, but personally I think that "||" > > > looks strange. Perhaps it would be better to add something like > > > --croot argument? > > > > > The || is ambiguous with its simmilarity to a shell 'or' command, > > Ah, I didn't mean this. > > I meant, this is not flexible. We can implement --croot, then we can > (may be) add --switch_ns. If you use "||" now for chroot, what will you > do for switch_ns? > > > but I don't > > think the --croot argument is much better on that front, as that then becomes > > ambiguous with arguments supplied to the pipe reader directly. > > Not sure I understand... why? > > > The token should > > be leading the pipe_reader string in core_pattern to indicate a change in > > environment independent of the executable path. > > Do you mean that || at the front is more "visible" ? True, but I am > not sure this is that important. > All I really meant was that placing the token for croot at the front of the pattern would be more readable as it disambiguates its meaning from the rest of the command. > But I won't insist. > I wouldn't worry about it. After looking over the changes Eric just had merged for 3.8 I'm becomming more convinced that this isn't really needed anymore. With his changes, we can migrate a process between all available namespaces dynamically in user space. With that functionality we can just write a setns administrative utility to make this all work. I've started that work here: http://marc.info/?l=util-linux-ng&m=135594402801895&w=2 all thats arguably left after that is to make core_pattern a per-container (possibly per mount namespace?). My patch doesn't do that. But its something I can look into. Neil > Oleg. > >