From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752439Ab2LTTbs (ORCPT ); Thu, 20 Dec 2012 14:31:48 -0500 Received: from mail.skyhub.de ([78.46.96.112]:51696 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751009Ab2LTTbl (ORCPT ); Thu, 20 Dec 2012 14:31:41 -0500 Date: Thu, 20 Dec 2012 20:31:38 +0100 From: Borislav Petkov To: Joe Perches Cc: Michal Marek , Cesar Eduardo Barros , linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, Andrew Morton , David Howells Subject: Re: [PATCH] scripts: add checkmaintainers.py Message-ID: <20121220193138.GH26635@liondog.tnic> Mail-Followup-To: Borislav Petkov , Joe Perches , Michal Marek , Cesar Eduardo Barros , linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, Andrew Morton , David Howells References: <1355770579.13361.41.camel@joe-AO722> <1355771383.13361.44.camel@joe-AO722> <20121218182838.GF31255@liondog.tnic> <1355859281.30366.29.camel@joe-AO722> <20121218203159.GI31255@liondog.tnic> <1355862997.30366.36.camel@joe-AO722> <20121218204716.GJ31255@liondog.tnic> <1355866399.3297.2.camel@joe-AO722> <20121219150732.GD24895@liondog.tnic> <1355939022.7430.4.camel@joe-AO722> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1355939022.7430.4.camel@joe-AO722> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 19, 2012 at 09:43:42AM -0800, Joe Perches wrote: > When I use this file > $ cat .git/hooks/pre-commit > exec git diff --cached HEAD -- | ./scripts/checkpatch.pl --strict - > $ > > it works fine. > ^ > Here's the latest checkpatch diff without that > concatenation warning for you to try. Yep, looks good. Add a proper commit message and ship it. Tested-by: Borislav Petkov Btw, you should credit Cesar in the commit message for the idea. Thanks. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. --