From: Gleb Natapov <gleb@redhat.com>
To: David Ahern <dsahern@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Arnaldo Carvalho de Melo <acme@infradead.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [GIT PULL] perf changes for v3.8
Date: Mon, 24 Dec 2012 12:36:20 +0200 [thread overview]
Message-ID: <20121224103620.GU17584@redhat.com> (raw)
In-Reply-To: <50D79119.9010002@gmail.com>
On Sun, Dec 23, 2012 at 04:17:45PM -0700, David Ahern wrote:
> On 12/23/12 2:23 AM, Gleb Natapov wrote:
> >>Your patch alone was not enough. Start here:
> >> https://lkml.org/lkml/2012/7/12/3
> >>
> >I cannot reproduce this failure. I reverted 20b279ddb38c and ran "perf
> >record -e cycles:ppG" while guest was running. Admittedly I ran the test
> >for a short time, but without disabling PEBS during the guest entry this
> >was enough to crash a guest.
>
> In the beginning (without any patches) VMs crashed fairly quickly.
> With your patch it took longer, but I was able to consistently crash
> VMs. The thread notes server info (processor, OS) and VM versions as
> well as load used for the tests -- a cpu bound process (openssl),
> disk bound (dd) and network (netperf).
>
>
It means that disabling PEBS is not enough and PMU counter should be
disabled too.
> >What about forcing exclude_guest on an event that
> >has precise flag set without reporting error to userspace?
>
> That's up to the perf maintainers -- Ingo, Peter, Arnaldo.
> Personally, I don't like it since kernel side is changing the user
> request.
>
I do not see other way to prevent guests from crashing with older perf
binaries if 20b279ddb38c will be reverted.
--
Gleb.
next prev parent reply other threads:[~2012-12-24 10:36 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-11 9:09 Ingo Molnar
2012-12-13 2:53 ` Linus Torvalds
2012-12-13 3:02 ` David Ahern
2012-12-13 3:09 ` Linus Torvalds
2012-12-13 3:16 ` David Ahern
2012-12-13 3:25 ` David Ahern
2012-12-13 3:34 ` Linus Torvalds
2012-12-13 3:43 ` David Ahern
2012-12-13 3:51 ` Linus Torvalds
2012-12-13 4:31 ` David Ahern
2012-12-13 4:46 ` Linus Torvalds
2012-12-13 7:27 ` Ingo Molnar
2012-12-13 7:30 ` Ingo Molnar
2012-12-13 14:30 ` David Ahern
2012-12-13 14:38 ` David Ahern
2012-12-13 16:03 ` Linus Torvalds
2012-12-13 16:24 ` David Ahern
2012-12-13 16:33 ` Linus Torvalds
2012-12-13 16:59 ` Ingo Molnar
2012-12-13 17:10 ` Linus Torvalds
2012-12-13 17:31 ` Ingo Molnar
2012-12-17 4:43 ` David Ahern
2012-12-22 19:22 ` David Ahern
2012-12-23 0:00 ` Linus Torvalds
2012-12-13 17:02 ` Linus Torvalds
2012-12-13 17:30 ` David Ahern
2012-12-13 17:36 ` Ingo Molnar
2012-12-13 19:12 ` David Ahern
2012-12-13 7:48 ` [PATCH] Revert "perf: Require exclude_guest to use PEBS - kernel side enforcement" Ingo Molnar
[not found] ` <20121217102000.GE11016@redhat.com>
2012-12-22 19:30 ` [GIT PULL] perf changes for v3.8 David Ahern
2012-12-23 9:23 ` Gleb Natapov
2012-12-23 23:17 ` David Ahern
2012-12-24 10:36 ` Gleb Natapov [this message]
2012-12-13 17:04 ` [PATCH] x86: fix perf build with uclibc toolchains Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121224103620.GU17584@redhat.com \
--to=gleb@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=dsahern@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome