From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Richard Hartmann <richih.mailinglist@gmail.com>
Cc: ibm-acpi-devel@lists.sourceforge.net, ibm-acpi@hmh.eng.br,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
platform-driver-x86@vger.kernel.org
Subject: Re: [ibm-acpi-devel] [PATCH] drivers/platform/x86/thinkpad_acpi.c: Handle HKEY event 0x6040
Date: Fri, 28 Dec 2012 08:10:13 -0200 [thread overview]
Message-ID: <20121228101013.GA15327@khazad-dum.debian.net> (raw)
In-Reply-To: <CAD77+gTj+EvuOTU9SZBXOv92YmBdy3EgH9vHwypeFtAJY6+Eyw@mail.gmail.com>
On Thu, 27 Dec 2012, Richard Hartmann wrote:
> On Thu, Dec 27, 2012 at 11:38 AM, Henrique de Moraes Holschuh <
> hmh@hmh.eng.br> wrote:
>
> > /* fallthrough */
> >
> [...]
>
> > and letting it proceed to the TP_HKEY_EV_KEY_NUMLOCK block.
> >
>
> OK.
>
>
> Also, do we have any confirmed reports about the lid switch
> > causing event 0x6040? It doesn't look right... the comment
> > might need to be updated.
> >
>
> I could not reproduce it on my X220. Would you prefer even stronger wording
> or should I get of it entirely?
If you cannot reproduce it, we can shalk it up to user error or to corrected
firmware bug, so you can remove any mention of lid open/close to event
6040...
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
next prev parent reply other threads:[~2012-12-28 10:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-26 17:46 Richard Hartmann
2012-12-27 5:51 ` Borislav Petkov
2012-12-27 10:38 ` Henrique de Moraes Holschuh
[not found] ` <CAD77+gTj+EvuOTU9SZBXOv92YmBdy3EgH9vHwypeFtAJY6+Eyw@mail.gmail.com>
2012-12-28 10:10 ` Henrique de Moraes Holschuh [this message]
[not found] <CAD77+gROUfVX=9LPZc6_jf=2Bc_iaf5FW5Z2efwESzORNrq9dQ@mail.gmail.com>
2012-12-29 21:51 ` Richard Hartmann
2012-12-30 2:00 ` [ibm-acpi-devel] " Henrique de Moraes Holschuh
[not found] ` <CAD77+gROHKXOBDAy8A4sLnzSnZXTz-KKomk4nqrEfapjNo03vA@mail.gmail.com>
2012-12-31 1:45 ` Henrique de Moraes Holschuh
2013-02-25 11:57 ` Richard Hartmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121228101013.GA15327@khazad-dum.debian.net \
--to=hmh@hmh.eng.br \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=ibm-acpi@hmh.eng.br \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=richih.mailinglist@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome