From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754683Ab2L1VlY (ORCPT ); Fri, 28 Dec 2012 16:41:24 -0500 Received: from mail-qa0-f44.google.com ([209.85.216.44]:64364 "EHLO mail-qa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753969Ab2L1VlU (ORCPT ); Fri, 28 Dec 2012 16:41:20 -0500 Date: Fri, 28 Dec 2012 16:41:15 -0500 From: Tejun Heo To: Bing Zhao Cc: "linux-kernel@vger.kernel.org" , "linux-wireless@vger.kernel.org" Subject: Re: [PATCH 07/25] mwifiex: don't use [delayed_]work_pending() Message-ID: <20121228214115.GE3062@mtj.dyndns.org> References: <1356141435-17340-1-git-send-email-tj@kernel.org> <1356141435-17340-8-git-send-email-tj@kernel.org> <477F20668A386D41ADCC57781B1F70430D13D8099B@SC-VEXCH1.marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <477F20668A386D41ADCC57781B1F70430D13D8099B@SC-VEXCH1.marvell.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 22, 2012 at 02:29:57PM -0800, Bing Zhao wrote: > Hi Tejun, > > Thanks for the patch. > > > Drop work_pending() test from mwifiex_sdio_card_reset(). As > > work_pending() becomes %false before sdio_card_reset_worker() starts > > executing, it doesn't really protect anything. reset_host may change > > between mmc_remove_host() and mmc_add_host(). Make > > sdio_card_reset_worker() cache the target mmc_host so that it isn't > > affected by mwifiex_sdio_card_reset() racing with it. > > > > Only compile tested. > > > > Signed-off-by: Tejun Heo > > Cc: Bing Zhao > > Cc: linux-wireless@vger.kernel.org > > Acked-by: Bing Zhao > > > --- > > Please let me know how this patch should be routed. I can take it > > through the workqueue tree if necessary. > > If you are taking other patches in this series through your tree, please take this one too. Applied to wq/for-3.9-cleanups. Thanks. -- tejun