From: "Serge E. Hallyn" <serge@hallyn.com>
To: Cyrill Gorcunov <gorcunov@openvz.org>
Cc: Eric Paris <eparis@redhat.com>,
Andrew Vagin <avagin@parallels.com>,
Andrey Vagin <avagin@openvz.org>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Kees Cook <keescook@chromium.org>,
Serge Hallyn <serge.hallyn@canonical.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
James Morris <jmorris@namei.org>
Subject: Re: [PATCH] prctl: fix validation of an address
Date: Mon, 31 Dec 2012 21:12:46 +0000 [thread overview]
Message-ID: <20121231211246.GA784@mail.hallyn.com> (raw)
In-Reply-To: <20121231151356.GA11118@moon>
Quoting Cyrill Gorcunov (gorcunov@openvz.org):
> > The kernel makes the decision on what is valid via security_mmap_addr().
> > Assuming there are no security fears of an untrusted application
> > tricking some priviledged application to set up these maps the answer is
> > just calling security_mmap_addr() instead of doing if(addr <
> > mmap_min_addr) return -EINVAL;
>
> If only I've not missed something obvious, the check for security_mmap_addr() here
> instead of poking the mmap_min_addr looks more correct for me. Andrew?
That sounds right to me as well.
-serge
next prev parent reply other threads:[~2012-12-31 21:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-29 11:00 Andrey Vagin
2012-12-30 22:03 ` Eric Paris
2012-12-31 10:14 ` Andrew Vagin
2012-12-31 14:27 ` Eric Paris
2012-12-31 15:13 ` Cyrill Gorcunov
2012-12-31 15:20 ` Eric Paris
2012-12-31 15:38 ` Cyrill Gorcunov
2012-12-31 21:12 ` Serge E. Hallyn [this message]
2013-01-01 8:26 ` Andrey Wagin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121231211246.GA784@mail.hallyn.com \
--to=serge@hallyn.com \
--cc=akpm@linux-foundation.org \
--cc=avagin@openvz.org \
--cc=avagin@parallels.com \
--cc=ebiederm@xmission.com \
--cc=eparis@redhat.com \
--cc=gorcunov@openvz.org \
--cc=jmorris@namei.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=serge.hallyn@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome