From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754893AbcLaWEE (ORCPT ); Sat, 31 Dec 2016 17:04:04 -0500 Received: from mout.web.de ([212.227.15.4]:62208 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754802AbcLaWEC (ORCPT ); Sat, 31 Dec 2016 17:04:02 -0500 Subject: [PATCH 4/6] staging: vchiq_arm: Delete an error message for a failed memory allocation in dump_phys_mem() To: devel@driverdev.osuosl.org, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, kbuild test robot , popcornmix@gmail.com, Eric Anholt , Greg Kroah-Hartman , Lee Jones , Stefan Wahren , Stephen Warren , Wei Yongjun References: <5acd65e7-0b5d-0972-5e1a-6e87d71dc1a4@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Wolfram Sang From: SF Markus Elfring Message-ID: <20128727-5313-ad6d-7938-ca9c303331a7@users.sourceforge.net> Date: Sat, 31 Dec 2016 23:03:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <5acd65e7-0b5d-0972-5e1a-6e87d71dc1a4@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:CeknxZpiINcm8LiOg2d/qwLxLgRJ4CZ2Apy0iCLpx2HoIgLaGpy +5gcOMSf1+yTO2cZAxBnwREzzZvAHIhIV64xZAbL0NcLxl8paPciikTwtkha//BRvA4RjfS uT0zu7iIjY32cFC6IZLvYm9SZ4Kib5BrK/X3q68JZu4Pvsf6oJZ241sXZlHE5oXjNvGz7Kp WVRg4BMpo8ct3qhUOMurw== X-UI-Out-Filterresults: notjunk:1;V01:K0:Z0zC2VIZX3I=:7cvQc4MYM4t6QV6J2fjH6a HWs7up881kCBSE0h4K3A4s8n8QHLDy/o0vAwmWJthvFmjpU+ZcndegV6senVKHclXcoOhjsJX t3/BkSA7hpA5oLLOHcoTLjhyAr3Zxa1t5sze4Glrs/vJH/Orn0vgGQtuUoU15bDGZBdY0d3M4 6EYFSJD7uaKUlFWjRk8Rjqs73bjweMTUH38JxMkscsmDMhVET+a7LXYR5qQ/bQJHGQEChIlZT q62DTwSAKVMEqm9RAx4qkYaN0pg7zPgn1NvAZf1W0Nx4m2CNyOkwBnlDux7/3KqV3H2upxU3k KPIoBCB1TLIN88clVCte80UgWAIuxbwUnlxrkPaiYXK9RmTeli7AmcU/BE32s+fbKBoHEznwA 4tA2Qd/+DsQ19NzbFPBECUZqnMPB9DqVtfOVQf2AbxvcZ3lq9LV8JWED/SHAbtCysDC40Fdlr UWAA2uFSoYdit8+1cYVYEjc7TwroJ0gJyxdqcHKgU1DuGzPT6vrMq5zgGEgq67O6E9IQZNi5Z EW4vYdsMoKiwVzhpo31U2FgwDUhYWvl+jp/7EZJkrBc+fbgO0UvsGQFvOFiAEmOQ7O32PhauT uruEGOGbEknzn5Yeiw0avnEtvTTjQPPwATmhmQfn6Lg8GnXeoDAdjw13P31i/XAiRRrhjPYO+ odKMOvJoGYVnNFZBmses3uFB3Xe3JUYSpS6zuuyICN9Oo9hAQz0CAJPVGOi3RXKzJqZ2jI1jY kau8srn7G0kPgaCvjuFh2CZTFOGcHpjFdrrV1MgX5tPNMj1WDvVG6wx1hn64wB9LWzYnRuofD wyqx4qP Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 31 Dec 2016 21:30:31 +0100 Omit an extra message for a memory allocation failure in this function. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c index a316cf9ac626..3b7a0c87954d 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c @@ -1559,12 +1559,8 @@ dump_phys_mem(void *virt_addr, uint32_t num_bytes) num_pages = (offset + num_bytes + PAGE_SIZE - 1) / PAGE_SIZE; pages = kmalloc_array(num_pages, sizeof(*pages), GFP_KERNEL); - if (!pages) { - vchiq_log_error(vchiq_arm_log_level, - "Unable to allocation memory for %d pages\n", - num_pages); + if (!pages) return; - } down_read(¤t->mm->mmap_sem); rc = get_user_pages( -- 2.11.0