From: Jeff Layton <jlayton@redhat.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Stephen Warren <swarren@wwwdotorg.org>,
"Theodore Ts'o" <tytso@mit.edu>
Subject: Re: [PATCH] vfs: Add missing errno.h inclusion to namei.h
Date: Wed, 2 Jan 2013 08:42:05 -0500 [thread overview]
Message-ID: <20130102084205.2320f6b9@tlielax.poochiereds.net> (raw)
In-Reply-To: <1357133786-29587-1-git-send-email-broonie@opensource.wolfsonmicro.com>
On Wed, 2 Jan 2013 13:36:26 +0000
Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
> In current -next namei.h now include/linux/namei.h uses ESTALE but does
> not include errno.h, leading to build failures on ARM where errno.h is
> not previously implicitly included by some other header as is the case
> in some bits of ext3. Fix this by adding a direct inclusion of errno.h.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> include/linux/namei.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/namei.h b/include/linux/namei.h
> index e998c03..5a5ff57 100644
> --- a/include/linux/namei.h
> +++ b/include/linux/namei.h
> @@ -2,6 +2,7 @@
> #define _LINUX_NAMEI_H
>
> #include <linux/dcache.h>
> +#include <linux/errno.h>
> #include <linux/linkage.h>
> #include <linux/path.h>
>
I think Ted and Stephen (cc'ed here) proposed the same patch a week or
so ago, but I'm not sure why Al hasn't pushed it yet.
--
Jeff Layton <jlayton@redhat.com>
next prev parent reply other threads:[~2013-01-02 13:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-02 13:36 Mark Brown
2013-01-02 13:42 ` Jeff Layton [this message]
2013-01-02 13:46 ` Mark Brown
2013-01-03 20:24 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130102084205.2320f6b9@tlielax.poochiereds.net \
--to=jlayton@redhat.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®