mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: Markus Trippelsdorf <markus@trippelsdorf.de>,
	Jerome Glisse <j.glisse@gmail.com>,
	Antti Palosaari <crope@iki.fi>, Shuah Khan <shuahkhan@gmail.com>,
	Andy Furniss <andyqos@ukfsn.org>,
	Alex Deucher <alexander.deucher@amd.com>,
	dri-devel@lists.freedesktop.org,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: radeon 0000:02:00.0: GPU lockup CP stall for more than 10000msec
Date: Fri, 4 Jan 2013 08:40:55 +0100	[thread overview]
Message-ID: <20130104074054.GB20905@x1.alien8.de> (raw)
In-Reply-To: <CADnq5_OuhJordwCQArknpdvzYLryouZ+u+a+tm37n3K+hmB9uw@mail.gmail.com>

On Wed, Jan 02, 2013 at 06:37:23PM -0500, Alex Deucher wrote:
> From: Alex Deucher <alexander.deucher@amd.com>
> Date: Wed, 2 Jan 2013 18:30:21 -0500
> Subject: [PATCH] drm/radeon/r6xx: fix DMA engine for ttm bo transfers
> 
> count must be a multiple of 2.
> 
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: Markus Trippelsdorf <markus@trippelsdorf.de>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

Thanks, will run it on the box in question next week when I have access.

Btw, you could add the note about count needing to be a multiple of 2 as
a comment in the code below, for future reference.

> ---
>  drivers/gpu/drm/radeon/r600.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/radeon/r600.c b/drivers/gpu/drm/radeon/r600.c
> index 2aaf147..9f4ce5e 100644
> --- a/drivers/gpu/drm/radeon/r600.c
> +++ b/drivers/gpu/drm/radeon/r600.c
> @@ -2636,8 +2636,8 @@ int r600_copy_dma(struct radeon_device *rdev,
>  
>  	for (i = 0; i < num_loops; i++) {
>  		cur_size_in_dw = size_in_dw;
> -		if (cur_size_in_dw > 0xFFFF)
> -			cur_size_in_dw = 0xFFFF;
> +		if (cur_size_in_dw > 0xFFFE)
> +			cur_size_in_dw = 0xFFFE;
>  		size_in_dw -= cur_size_in_dw;
>  		radeon_ring_write(ring, DMA_PACKET(DMA_PACKET_COPY, 0, 0, cur_size_in_dw));
>  		radeon_ring_write(ring, dst_offset & 0xfffffffc);
> -- 
> 1.7.7.5

-- 
Regards/Gruss,
Boris.

  parent reply	other threads:[~2013-01-04  7:40 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-22 20:35 Borislav Petkov
2012-12-23  0:01 ` Alex Deucher
2012-12-23  0:25   ` Borislav Petkov
2012-12-23  0:42     ` Alex Deucher
2012-12-23 10:55       ` Borislav Petkov
2012-12-23 11:01         ` Andy Furniss
2012-12-23 11:07           ` Borislav Petkov
2012-12-23 11:19             ` Andy Furniss
2012-12-23 11:31               ` Borislav Petkov
2012-12-23 11:51                 ` Markus Trippelsdorf
2012-12-23 12:22                   ` Borislav Petkov
2012-12-23 13:31                     ` Borislav Petkov
2012-12-25  4:50                       ` Shuah Khan
2012-12-25 10:54                         ` Borislav Petkov
2013-01-02  1:42                         ` Antti Palosaari
2013-01-02 12:02                           ` Borislav Petkov
2013-01-02 17:19                             ` Jerome Glisse
2013-01-02 17:58                               ` Antti Palosaari
2013-01-02 22:31                                 ` Jerome Glisse
2013-01-02 22:38                                   ` Markus Trippelsdorf
2013-01-02 23:37                                     ` Alex Deucher
2013-01-02 23:58                                       ` Shuah Khan
2013-01-02 23:59                                         ` Alex Deucher
2013-01-03  1:03                                           ` Antti Palosaari
2013-01-03  1:05                                           ` Shuah Khan
2013-01-03  8:33                                       ` Markus Trippelsdorf
2013-01-03 11:37                                       ` Boszormenyi Zoltan
2013-01-03 14:12                                         ` Deucher, Alexander
2013-01-03 15:30                                           ` Shuah Khan
2013-01-04  7:40                                       ` Borislav Petkov [this message]
2013-01-04 11:16                                         ` Boszormenyi Zoltan
2013-01-04 14:06                                           ` Alex Deucher
2012-12-23 11:52           ` Joe Perches
2013-01-10  9:38 Borislav Petkov
2013-01-10 16:21 ` Alex Deucher
2013-01-10 20:32   ` Borislav Petkov
2013-01-10 20:47     ` Alex Deucher
2013-01-11 11:43       ` Borislav Petkov
2013-01-15 12:19         ` Borislav Petkov
2013-01-15 14:04           ` Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130104074054.GB20905@x1.alien8.de \
    --to=bp@alien8.de \
    --cc=alexander.deucher@amd.com \
    --cc=alexdeucher@gmail.com \
    --cc=andyqos@ukfsn.org \
    --cc=crope@iki.fi \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=j.glisse@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markus@trippelsdorf.de \
    --cc=shuahkhan@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®