From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Nickolai Zeldovich <nickolai@csail.mit.edu>
Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH] drivers/input/keyboard/lm8323.c: fix incorrect left shift
Date: Sat, 5 Jan 2013 15:01:25 -0800 [thread overview]
Message-ID: <20130105230125.GA6475@core.coreip.homeip.net> (raw)
In-Reply-To: <1357412945-41774-1-git-send-email-nickolai@csail.mit.edu>
On Sat, Jan 05, 2013 at 02:09:05PM -0500, Nickolai Zeldovich wrote:
> In drivers/input/keyboard/lm8323.c, INT_PWM1 is already a bitmask,
> not the bit number, so shifting by INT_PWM1 is incorrect.
>
> Signed-off-by: Nickolai Zeldovich <nickolai@csail.mit.edu>
Applied, thank you Nickolai.
> ---
> drivers/input/keyboard/lm8323.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/keyboard/lm8323.c b/drivers/input/keyboard/lm8323.c
> index 93c8126..0de23f4 100644
> --- a/drivers/input/keyboard/lm8323.c
> +++ b/drivers/input/keyboard/lm8323.c
> @@ -398,7 +398,7 @@ static irqreturn_t lm8323_irq(int irq, void *_lm)
> lm8323_configure(lm);
> }
> for (i = 0; i < LM8323_NUM_PWMS; i++) {
> - if (ints & (1 << (INT_PWM1 + i))) {
> + if (ints & (INT_PWM1 << i)) {
> dev_vdbg(&lm->client->dev,
> "pwm%d engine completed\n", i);
> pwm_done(&lm->pwm[i]);
> --
> 1.7.10.4
>
--
Dmitry
parent reply other threads:[~2013-01-05 23:01 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1357412945-41774-1-git-send-email-nickolai@csail.mit.edu>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130105230125.GA6475@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nickolai@csail.mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®