From: Anton Vorontsov <anton@enomsg.org>
To: Ramakrishna Pallala <ramakrishna.pallala@intel.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] power_supply: add watchdog and safety timer expiries under PROP_HEALTH_*
Date: Sat, 5 Jan 2013 18:52:47 -0800 [thread overview]
Message-ID: <20130106025246.GD6919@lizard.sbx05280.losalca.wayport.net> (raw)
In-Reply-To: <1354264066-3523-1-git-send-email-ramakrishna.pallala@intel.com>
On Fri, Nov 30, 2012 at 01:57:46PM +0530, Ramakrishna Pallala wrote:
> As most of the charger chips come with two kinds of safety features
> related to timing.
> 1. Watchdog Timer (interms of seconds/mins)
> 2. Safety Timer (interms of hours)
>
> This patch adds these to fault causes in POWER_SUPPLY_PROP_HEALTH_*
> enums so that whenever there is either watchdog timeout or safety timer
> timeout driver could notify the user space accurately about the fault
> and will also be helpful for debug.
>
> Signed-off-by: Ramakrishna Pallala <ramakrishna.pallala@intel.com>
Applied, thanks a lot!
> ---
> drivers/power/power_supply_sysfs.c | 3 ++-
> include/linux/power_supply.h | 2 ++
> 2 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/power/power_supply_sysfs.c b/drivers/power/power_supply_sysfs.c
> index 40fa3b7..29178f7 100644
> --- a/drivers/power/power_supply_sysfs.c
> +++ b/drivers/power/power_supply_sysfs.c
> @@ -55,7 +55,8 @@ static ssize_t power_supply_show_property(struct device *dev,
> };
> static char *health_text[] = {
> "Unknown", "Good", "Overheat", "Dead", "Over voltage",
> - "Unspecified failure", "Cold",
> + "Unspecified failure", "Cold", "Watchdog timer expire",
> + "Safety timer expire"
> };
> static char *technology_text[] = {
> "Unknown", "NiMH", "Li-ion", "Li-poly", "LiFe", "NiCd",
> diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h
> index 35cdf2c..4e672e1 100644
> --- a/include/linux/power_supply.h
> +++ b/include/linux/power_supply.h
> @@ -54,6 +54,8 @@ enum {
> POWER_SUPPLY_HEALTH_OVERVOLTAGE,
> POWER_SUPPLY_HEALTH_UNSPEC_FAILURE,
> POWER_SUPPLY_HEALTH_COLD,
> + POWER_SUPPLY_HEALTH_WATCHDOG_TIMER_EXPIRE,
> + POWER_SUPPLY_HEALTH_SAFETY_TIMER_EXPIRE,
> };
>
> enum {
> --
> 1.7.0.4
prev parent reply other threads:[~2013-01-06 2:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-30 8:27 Ramakrishna Pallala
2013-01-06 2:52 ` Anton Vorontsov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130106025246.GD6919@lizard.sbx05280.losalca.wayport.net \
--to=anton@enomsg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ramakrishna.pallala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®