From: Anton Vorontsov <anton@enomsg.org>
To: "Pallala, Ramakrishna" <ramakrishna.pallala@intel.com>
Cc: "Tc, Jenny" <jenny.tc@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Myungjoo Ham <myungjoo.ham@samsung.com>
Subject: Re: [PATCH 1/2] power_supply: Add charge control struct in power supply class
Date: Sun, 6 Jan 2013 22:11:13 -0800 [thread overview]
Message-ID: <20130107061113.GA26891@lizard.gateway.2wire.net> (raw)
In-Reply-To: <D854C92F57B1B347B57E531E78D05EAD245CB0F3@BGSMSX102.gar.corp.intel.com>
On Mon, Jan 07, 2013 at 05:43:58AM +0000, Pallala, Ramakrishna wrote:
> > > > > +struct power_supply_charger_control {
> > > > > + const char *name;
> > > > > + /* get charging status */
> > > > > + int (*is_charging_enabled)(void);
> > > > > + int (*is_charger_enabled)(void);
[...]
> > The similar functionalities are exposed by patch
> > https://lkml.org/lkml/2012/10/18/219.
> > As per Anton's review comments on this patch, I'll be moving the macros to
> > power_supply.h.
> > Wouldn't that be enough ?
>
> Though the macros seem to be fine but I would still think that call back way of interfaces would be
> More flexible and straightforward.
We have properties mechanism deployed already, so I'd rather keep it
consistent.
p.s. We had 'properties vs. callbacks' debates before, there are pros and
cons of each approach. Unless there are some unresolvable issues, let's
stick with the original approach. :)
next prev parent reply other threads:[~2013-01-07 6:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-27 7:47 [PATCH 0/2] power supply class support for charger managers Ramakrishna Pallala
2012-11-27 7:47 ` [PATCH 1/2] power_supply: Add charge control struct in power supply class Ramakrishna Pallala
2013-01-06 2:50 ` Anton Vorontsov
2013-01-07 5:09 ` Pallala, Ramakrishna
2013-01-07 5:23 ` Tc, Jenny
2013-01-07 5:35 ` Anton Vorontsov
2013-01-07 5:47 ` Pallala, Ramakrishna
2013-01-07 5:43 ` Pallala, Ramakrishna
2013-01-07 6:11 ` Anton Vorontsov [this message]
2012-11-27 7:47 ` [PATCHv2 2/2] charger_manager: Enable power supply driver support for charge controls Ramakrishna Pallala
-- strict thread matches above, loose matches on Subject: below --
2012-11-27 7:39 [PATCH 0/2] power supply class support for charger managers Ramakrishna Pallala
2012-11-27 7:39 ` [PATCH 1/2] power_supply: Add charge control struct in power supply class Ramakrishna Pallala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130107061113.GA26891@lizard.gateway.2wire.net \
--to=anton@enomsg.org \
--cc=jenny.tc@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=ramakrishna.pallala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®