From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754428Ab3AGRBa (ORCPT ); Mon, 7 Jan 2013 12:01:30 -0500 Received: from mail-pb0-f42.google.com ([209.85.160.42]:38228 "EHLO mail-pb0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752126Ab3AGRB2 (ORCPT ); Mon, 7 Jan 2013 12:01:28 -0500 Date: Mon, 7 Jan 2013 09:01:24 -0800 From: Tejun Heo To: Lin Feng Cc: akpm@linux-foundation.org, mingo@kernel.org, yinghai@kernel.org, liwanp@linux.vnet.ibm.com, benh@kernel.crashing.org, tangchen@cn.fujitsu.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm: memblock: fix wrong memmove size in memblock_merge_regions() Message-ID: <20130107170124.GK3926@htj.dyndns.org> References: <1357530096-28548-1-git-send-email-linfeng@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1357530096-28548-1-git-send-email-linfeng@cn.fujitsu.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 07, 2013 at 11:41:36AM +0800, Lin Feng wrote: > The memmove span covers from (next+1) to the end of the array, and the index > of next is (i+1), so the index of (next+1) is (i+2). So the size of remaining > array elements is (type->cnt - (i + 2)). > > Cc: Tejun Heo > Reviewed-by: Wanpeng Li > Signed-off-by: Lin Feng Acked-by: Tejun Heo Thanks! -- tejun