mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
	Nickolai Zeldovich <nickolai@csail.mit.edu>,
	William Hubbs <w.d.hubbs@gmail.com>,
	Chris Brannon <chris@the-brannons.com>,
	Kirk Reiser <kirk@braille.uwo.ca>,
	linux-kernel@vger.kernel.org, speakup@braille.uwo.ca
Subject: Re: [PATCH] drivers/staging/speakup: avoid out-of-range access
Date: Mon, 7 Jan 2013 09:44:53 -0800	[thread overview]
Message-ID: <20130107174453.GA15120@kroah.com> (raw)
In-Reply-To: <20130105192944.GL5965@type.youpi.perso.aquilenet.fr>

On Sat, Jan 05, 2013 at 08:29:44PM +0100, Samuel Thibault wrote:
> Indeed. The same happens in synth_add, so Greg please use this instead:
> 
> 
> Check that array index is in-bounds before accessing the synths[] array.
> 
> Signed-off-by: Nickolai Zeldovich <nickolai@csail.mit.edu>
> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

Wait, Nickolai wrote the first patch, so how could he sign off on your
patch?  How about sending me an add-on patch on top of the first one
which adds the additional check?  That way I'll apply both of them and
everyone will get the proper credit?

thanks,

greg k-h

  reply	other threads:[~2013-01-07 17:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1357413465-42357-1-git-send-email-nickolai@csail.mit.edu>
2013-01-05 19:29 ` Samuel Thibault
2013-01-07 17:44   ` Greg KH [this message]
2013-01-07 21:03     ` Samuel Thibault

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130107174453.GA15120@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=chris@the-brannons.com \
    --cc=kirk@braille.uwo.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nickolai@csail.mit.edu \
    --cc=samuel.thibault@ens-lyon.org \
    --cc=speakup@braille.uwo.ca \
    --cc=w.d.hubbs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®