From: Greg KH <gregkh@linuxfoundation.org>
To: Durgadoss R <durgadoss.r@intel.com>
Cc: rui.zhang@intel.com, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, eduardo.valentin@ti.com,
hongbo.zhang@linaro.org, wni@nvidia.com
Subject: Re: [PATCH 3/9] Thermal: Add APIs to bind cdev to new zone structure
Date: Mon, 7 Jan 2013 11:26:02 -0800 [thread overview]
Message-ID: <20130107192602.GD4465@kroah.com> (raw)
In-Reply-To: <1357542806-20449-4-git-send-email-durgadoss.r@intel.com>
On Mon, Jan 07, 2013 at 12:43:20PM +0530, Durgadoss R wrote:
> +struct thermal_cooling_device *get_cdev_by_name(const char *name)
> +{
> + struct thermal_cooling_device *pos;
> + struct thermal_cooling_device *cdev = NULL;
> +
> + mutex_lock(&cdev_list_lock);
> + for_each_cdev(pos) {
> + if (!strnicmp(pos->type, name, THERMAL_NAME_LENGTH)) {
> + cdev = pos;
> + break;
> + }
> + }
> + mutex_unlock(&cdev_list_lock);
> + return cdev;
> +}
> +EXPORT_SYMBOL(get_cdev_by_name);
EXPORT_SYMBOL_GPL?
You also forgot to increment the reference count, which is required for
all reference counted objects.
thanks,
greg k-h
next prev parent reply other threads:[~2013-01-07 19:26 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-07 7:13 [PATCHv2 0/9] Thermal Framework Enhancements Durgadoss R
2013-01-07 7:13 ` [PATCH 1/9] Thermal: Create sensor level APIs Durgadoss R
2013-01-07 7:13 ` [PATCH 2/9] Thermal: Create zone " Durgadoss R
2013-01-07 7:13 ` [PATCH 3/9] Thermal: Add APIs to bind cdev to new zone structure Durgadoss R
2013-01-07 19:26 ` Greg KH [this message]
2013-01-09 9:21 ` R, Durgadoss
2013-01-09 17:01 ` Greg KH
2013-01-07 7:13 ` [PATCH 4/9] Thermal: Add trip point sysfs nodes for sensor Durgadoss R
2013-01-07 7:13 ` [PATCH 5/9] Thermal: Create 'mapX' sysfs node for a zone Durgadoss R
2013-01-07 19:21 ` Greg KH
2013-01-10 12:50 ` R, Durgadoss
2013-01-10 14:28 ` Greg KH
2013-01-07 7:13 ` [PATCH 6/9] Thermal: Add Documentation to new APIs Durgadoss R
2013-01-07 8:40 ` Wei Ni
2013-01-07 8:53 ` R, Durgadoss
2013-01-07 9:28 ` Wei Ni
2013-01-16 8:04 ` Mattias NILSSON1
2013-01-07 7:13 ` [PATCH 7/9] Thermal: Make PER_ZONE values configurable Durgadoss R
2013-01-07 19:24 ` Greg KH
2013-01-09 9:12 ` R, Durgadoss
2013-01-09 17:00 ` Greg KH
2013-01-10 12:43 ` R, Durgadoss
2013-01-10 14:27 ` Greg KH
2013-01-07 7:13 ` [PATCH 8/9] Thermal: Add ABI Documentation for sysfs interfaces Durgadoss R
2013-02-19 9:10 ` Pavel Machek
2013-01-07 7:13 ` [PATCH 9/9] Thermal: Dummy driver used for testing Durgadoss R
2013-01-07 19:23 ` Greg KH
2013-01-21 10:10 ` [PATCHv2 0/9] Thermal Framework Enhancements Wei Ni
2013-02-04 5:39 ` Wei Ni
2013-02-04 6:37 ` R, Durgadoss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130107192602.GD4465@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=durgadoss.r@intel.com \
--cc=eduardo.valentin@ti.com \
--cc=hongbo.zhang@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=wni@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome