mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Vinod Koul <vinod.koul@intel.com>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	Viresh Kumar <viresh.kumar@linaro.org>
Subject: Re: linux-next: comment in commit in the slave-dma tree (dmaengine: dw_dmac: Enhance device tree support)
Date: Tue, 8 Jan 2013 09:57:52 +1100	[thread overview]
Message-ID: <20130108095752.9e1529a2d32d0635490cd16e@canb.auug.org.au> (raw)
In-Reply-To: <20130107224308.GB27477@kroah.com>

[-- Attachment #1: Type: text/plain, Size: 2655 bytes --]

Hi Greg,

On Mon, 7 Jan 2013 14:43:08 -0800 Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
>
> That brings up something I wanted to ask you.
> 
> I'd like to send a patch to Linus to just delete __devinit and friends
> entirely from init.h, but that will break the linux-next tree from
> building in places (like this one, and in a few others.)
> 
> Is that ok?  That should finally get everyone's attention and keep them
> from the cargo-cult programming mode of using these attributes :)

I guess I can apply fixup patches that just remove any instances that
turn up ... and you and the tree owner will get copies of those.

So, if Linus takes it, I will cope.

This is what "git grep -E '__dev(init|exit)'" returns for next-20130107:

arch/ia64/kernel/iosapic.c: *				__init/__devinit attributes.
drivers/dma/dw_dmac.c:__devinit dw_dma_parse_dt(struct platform_device *pdev)
drivers/media/platform/sh_veu.c:static int __devinit sh_veu_probe(struct platform_device *pdev)
drivers/media/platform/sh_veu.c:static int __devexit sh_veu_remove(struct platform_device *pdev)
drivers/media/platform/sh_veu.c:	.remove		= __devexit_p(sh_veu_remove),
drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c:static int __devinit
drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c:static void __devexit qlcnic_remove(struct pci_dev *pdev)
drivers/power/reset/restart-poweroff.c:static int __devinit restart_poweroff_probe(struct platform_device *pdev)
drivers/power/reset/restart-poweroff.c:static int __devexit restart_poweroff_remove(struct platform_device *pdev)
drivers/power/reset/restart-poweroff.c:	.remove = __devexit_p(restart_poweroff_remove),
drivers/regulator/lp8755.c:	.remove = __devexit_p(lp8755_remove),
drivers/scsi/ipr.c:static int __devinit ipr_enable_msix(struct ipr_ioa_cfg *ioa_cfg)
drivers/scsi/ipr.c:static int __devinit ipr_enable_msi(struct ipr_ioa_cfg *ioa_cfg)
drivers/scsi/ipr.c:static void __devinit name_msi_vectors(struct ipr_ioa_cfg *ioa_cfg)
drivers/scsi/ipr.c:static int __devinit ipr_request_other_msi_irqs(struct ipr_ioa_cfg *ioa_cfg)
drivers/scsi/ips.c:/* 5.30.00  - use __devexit_p()                                              */
scripts/tags.sh:	-I __initdata,__exitdata,__initconst,__devinitdata	\
scripts/tags.sh:	-I __devinitconst,__cpuinitdata,__initdata_memblock	\
sound/oss/swarm_cs4297a.c:* 11/10/00 bkz - added __devinit to cs4297a_hw_init()

so there are just a few left.

BTW, I am *not* reporting merge fixes I am doing due to your tree wide
removal of __dev*, but they are still turning up :-(

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2013-01-07 22:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-07 22:35 Stephen Rothwell
2013-01-07 22:43 ` Greg Kroah-Hartman
2013-01-07 22:57   ` Stephen Rothwell [this message]
2013-01-08  8:19   ` Vinod Koul
2013-01-08  4:49 ` Viresh Kumar
2013-01-08  8:20   ` Vinod Koul
2013-01-08  8:17 ` Vinod Koul
2013-01-08 11:36   ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130108095752.9e1529a2d32d0635490cd16e@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=vinod.koul@intel.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®