From: Richard Cochran <richardcochran@gmail.com>
To: Florian Fainelli <florian@openwrt.org>
Cc: giometti@enneenne.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pps: hide more configuration symbols behind CONFIG_PPS
Date: Tue, 8 Jan 2013 17:27:54 +0100 [thread overview]
Message-ID: <20130108162754.GB7643@netboy.at.omicron.at> (raw)
In-Reply-To: <1357649962-14664-1-git-send-email-florian@openwrt.org>
On Tue, Jan 08, 2013 at 01:59:22PM +0100, Florian Fainelli wrote:
> This patch makes CONFIG_PPS_DEBUG and CONFIG_NTP_PPS be hidden if
> CONFIG_PPS is not selected, such that we are not prompted for these
> configuration options if CONFIG_PPS is not set.
>
> Signed-off-by: Florian Fainelli <florian@openwrt.org>
> ---
> drivers/pps/Kconfig | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/pps/Kconfig b/drivers/pps/Kconfig
> index 982d16b..dc19fb4 100644
> --- a/drivers/pps/Kconfig
> +++ b/drivers/pps/Kconfig
> @@ -21,6 +21,8 @@ config PPS
> To compile this driver as a module, choose M here: the module
> will be called pps_core.ko.
>
> +if PPS
> +
If you add this "if" ...
> config PPS_DEBUG
> bool "PPS debugging messages"
> depends on PPS
... then you should delete this redundant "depends".
Thanks,
Richard
next prev parent reply other threads:[~2013-01-08 16:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-08 12:59 Florian Fainelli
2013-01-08 16:27 ` Richard Cochran [this message]
2013-01-15 16:24 ` [PATCH v2] " Florian Fainelli
2013-04-04 14:07 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130108162754.GB7643@netboy.at.omicron.at \
--to=richardcochran@gmail.com \
--cc=florian@openwrt.org \
--cc=giometti@enneenne.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®