From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755901Ab3AIKfY (ORCPT ); Wed, 9 Jan 2013 05:35:24 -0500 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:42613 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752199Ab3AIKfX (ORCPT ); Wed, 9 Jan 2013 05:35:23 -0500 Date: Wed, 9 Jan 2013 10:35:10 +0000 From: Russell King - ARM Linux To: Arnd Bergmann Cc: Lee Jones , sameo@linux.intel.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linus.walleij@stericsson.com Subject: Re: [PATCH 2/3] ARM: ux500: Turn on the 'heartbeat' LED trigger Message-ID: <20130109103510.GE3931@n2100.arm.linux.org.uk> References: <1357725965-27342-1-git-send-email-lee.jones@linaro.org> <1357725965-27342-2-git-send-email-lee.jones@linaro.org> <201301091018.55058.arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201301091018.55058.arnd@arndb.de> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 09, 2013 at 10:18:54AM +0000, Arnd Bergmann wrote: > On Wednesday 09 January 2013, Lee Jones wrote: > > diff --git a/arch/arm/mach-ux500/Kconfig b/arch/arm/mach-ux500/Kconfig > > index 5dea906..0f25b07 100644 > > --- a/arch/arm/mach-ux500/Kconfig > > +++ b/arch/arm/mach-ux500/Kconfig > > @@ -43,6 +43,8 @@ config MACH_HREFV60 > > config MACH_SNOWBALL > > bool "U8500 Snowball platform" > > select MACH_MOP500 > > + select LEDS_TRIGGERS > > + select LEDS_TRIGGER_HEARTBEAT > > help > > Include support for the snowball development platform. > > Be careful with "select" statements like this when there are other > dependencies. I think LEDS_TRIGGERS depends on LEDS_CLASS, so this > should probably be written as > > select LEDS_TRIGGERS if LEDS_CLASS Umm, this is also wrong for another reason. LEDS is an optional feature. It's not required for the platform to be functional. So why the hell would anyone want to _force_ such an optional feature to be mandatory? This is something that the default config published for the platform should be handling.