From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Lee Jones <lee.jones@linaro.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
sameo@linux.intel.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linus.walleij@stericsson.com
Subject: Re: [PATCH 2/3] ARM: ux500: Turn on the 'heartbeat' LED trigger
Date: Wed, 9 Jan 2013 12:38:53 +0000 [thread overview]
Message-ID: <20130109123853.GJ3931@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20130109122323.GE31678@gmail.com>
On Wed, Jan 09, 2013 at 12:23:23PM +0000, Lee Jones wrote:
> Excuse my ignorance, but I'm a little confused by this.
>
> What's the difference between 'select <OPTION>' in the Kconfig and
> 'CONFIG_<OPTION>=y' in the defconfig; besides the fact that if we
> do it in the Kconfig file, we can be more selective with regards to
> which platform it gets enabled on?
Take this in Kconfig:
config FOO
bool "FOO option"
select BAR
config BAR
bool "BAR option"
Now, irrespective of the default configuration file being used:
- if you don't enable FOO, then you can enable _and_ _disable_ BAR according
to your needs.
- if you enable FOO, then BAR will be _forcefully_ enabled and you can't
turn it off without first disabling FOO.
The default configuration file will specify the _default_ values for these
options, but if FOO ends up being enabled, BAR will be forcefully enabled
irrespective of what's in the configuration file.
With this instead:
config FOO
bool "FOO option"
config BAR
bool "BAR option"
Then, the two options are independent. They can be enabled and disabled
by the configuration completely independently. However, their default
values come from the default configuration file. So, if the config file
has:
CONFIG_FOO=y
CONFIG_BAR=y
and you do a 'make oldconfig' then they will remain set. If you use one
of the configuration editing tools, you'll be presented with them already
enabled, and you can turn them off independently.
So, putting this stuff in the default configuration file allows
_non-mandatory_ options to be disabled should the user desire without the
user having to edit the configuration files.
If a user has to edit the configuration files in order to configure the
kernel as they desire, then the configuration system has failed - or we
have failed to properly think out how to represent the allowable
configurations.
next prev parent reply other threads:[~2013-01-09 12:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-09 10:06 [PATCH 1/3] mfd: Fix compile errors and warnings when !CONFIG_AB8500_BM Lee Jones
2013-01-09 10:06 ` [PATCH 2/3] ARM: ux500: Turn on the 'heartbeat' LED trigger Lee Jones
2013-01-09 10:18 ` Arnd Bergmann
2013-01-09 10:35 ` Russell King - ARM Linux
2013-01-09 11:08 ` Lee Jones
2013-01-09 11:12 ` Russell King - ARM Linux
2013-01-09 11:56 ` Arnd Bergmann
2013-01-09 11:59 ` Russell King - ARM Linux
2013-01-09 12:02 ` Arnd Bergmann
2013-01-09 12:23 ` Lee Jones
2013-01-09 12:38 ` Russell King - ARM Linux [this message]
2013-01-09 13:00 ` Lee Jones
2013-01-17 10:22 ` Linus Walleij
2013-01-09 10:06 ` [PATCH 3/3] ARM: ux500: Add Snowball pin configuration for user LED Lee Jones
2013-01-23 9:36 ` Linus Walleij
2013-02-26 10:32 ` Lee Jones
2013-01-22 3:26 ` [PATCH 1/3] mfd: Fix compile errors and warnings when !CONFIG_AB8500_BM Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130109123853.GJ3931@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=arnd@arndb.de \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®