From: "Peter Hüwe" <PeterHuewe@gmx.de>
To: tpmdd-devel@lists.sourceforge.net
Cc: Mathias LEBLANC <Mathias.LEBLANC@st.com>,
Kent Yoder <key@linux.vnet.ibm.com>,
"Jean-Luc BLANC" <jean-luc.blanc@st.com>,
"Sirrix@jasper.es" <Sirrix@jasper.es>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Kent Yoder <shpedoikal@gmail.com>
Subject: Re: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics ST33 I2C KERNEL 3.x.x OOPS!
Date: Wed, 9 Jan 2013 20:41:18 +0100 [thread overview]
Message-ID: <201301092041.18888.PeterHuewe@gmx.de> (raw)
In-Reply-To: <35286B1AE75A7C47BFF0870081A31B4B3A9E2CB82D@SAFEX1MAIL4.st.com>
Hi,
> Do you have the I2C configuration activated ?
> I have this error when I add the driver in a kernel with no I2C activated
I2C works fine on my beaglebone, however I did not add the platform data to my
boardfile.
a) as I don't use board files anymore but device trees ;)
b) it's perfectly legit to load a driver without the platform data and probe
it at runtime (which then in doubt fails to probe).
In my opinion a driver should never ever oops, even if the user does something
stupid (e.g. like probing from userspace ;)
The fix is as simple as adding a simple
if (!platform_data) return -ENODEV;
or something similar.
Thanks,
Peter
next prev parent reply other threads:[~2013-01-09 19:38 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-19 22:15 [PATCH 1/1] TPM: STMicroelectronics ST33 I2C KERNEL 3.x.x Mathias Leblanc
2012-11-19 22:15 ` [PATCH 1/1] TPM: STMicroelectronics ST33 I2C KERNEL 2.6 Mathias Leblanc
2012-11-26 17:46 ` [PATCH 1/1] TPM: STMicroelectronics ST33 I2C KERNEL 3.x.x Kent Yoder
2012-11-27 8:44 ` Mathias LEBLANC
2012-11-27 14:48 ` [tpmdd-devel] " Kent Yoder
2012-11-28 8:54 ` Mathias LEBLANC
2012-11-28 15:31 ` Kent Yoder
2012-11-28 17:48 ` Mathias LEBLANC
2012-11-28 19:04 ` Kent Yoder
2012-11-29 0:04 ` Peter Hüwe
2012-12-05 16:11 ` Mathias LEBLANC
2012-12-05 17:13 ` Kent Yoder
2012-12-05 17:45 ` Kent Yoder
2012-12-05 18:07 ` Kent Yoder
2012-12-05 20:20 ` Peter Hüwe
2012-12-05 21:00 ` Kent Yoder
2012-12-05 21:39 ` Peter Hüwe
2012-12-05 21:14 ` Peter Hüwe
2012-12-05 23:09 ` Kent Yoder
2012-12-06 0:10 ` Peter Hüwe
2012-12-06 15:06 ` Kent Yoder
2012-12-08 4:00 ` [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics ST33 I2C KERNEL 3.x.x OOPS! Peter Hüwe
[not found] ` <20130108172053.GA11223@ennui.austin.ibm.com>
2013-01-09 14:31 ` Mathias LEBLANC
2013-01-09 19:41 ` Peter Hüwe [this message]
2013-01-22 23:30 ` Kent Yoder
2012-12-06 0:20 ` [PATCH] char/tpm: Use struct dev_pm_ops for power management Peter Huewe
2012-12-06 15:07 ` Kent Yoder
2012-12-10 18:11 ` Mathias LEBLANC
2012-12-06 16:27 ` Kent Yoder
2012-12-08 3:55 ` Peter Hüwe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201301092041.18888.PeterHuewe@gmx.de \
--to=peterhuewe@gmx.de \
--cc=Mathias.LEBLANC@st.com \
--cc=Sirrix@jasper.es \
--cc=jean-luc.blanc@st.com \
--cc=key@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shpedoikal@gmail.com \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome