From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754607Ab3AKMNh (ORCPT ); Fri, 11 Jan 2013 07:13:37 -0500 Received: from mail.skyhub.de ([78.46.96.112]:37664 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752409Ab3AKMNf (ORCPT ); Fri, 11 Jan 2013 07:13:35 -0500 Date: Fri, 11 Jan 2013 13:13:33 +0100 From: Borislav Petkov To: Yinghai Lu Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , "Eric W. Biederman" , Andrew Morton , Jan Kiszka , Jason Wessel , linux-kernel@vger.kernel.org Subject: Re: [PATCH v7u1 10/31] x86, 64bit: Don't set max_pfn_mapped wrong value early on native path Message-ID: <20130111121333.GB10751@liondog.tnic> Mail-Followup-To: Borislav Petkov , Yinghai Lu , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , "Eric W. Biederman" , Andrew Morton , Jan Kiszka , Jason Wessel , linux-kernel@vger.kernel.org References: <1357260531-11115-1-git-send-email-yinghai@kernel.org> <1357260531-11115-11-git-send-email-yinghai@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1357260531-11115-11-git-send-email-yinghai@kernel.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 03, 2013 at 04:48:30PM -0800, Yinghai Lu wrote: > We are not having max_pfn_mapped set correctly until init_memory_mapping. > > so don't print it initial value for 64bit Just a minor nitpick: "So don't print its initial value for 64bit." And you don't need the newlines between each sentence. > Also need to use KERNEL_IMAGE_SIZE directly for highmap cleanup. > > Signed-off-by: Yinghai Lu Other than that, this commit message actually reads very good. :-) Acked-by: Borislav Petkov Thanks. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. --