From: David Miller <davem@davemloft.net>
To: florian@openwrt.org
Cc: netdev@vger.kernel.org, konszert@marvell.com, afleming@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: phy: remove flags argument from phy_{attach,connect,connect_direct}
Date: Mon, 14 Jan 2013 15:12:14 -0500 (EST) [thread overview]
Message-ID: <20130114.151214.1296751187134652417.davem@davemloft.net> (raw)
In-Reply-To: <1358160772-29631-1-git-send-email-florian@openwrt.org>
From: Florian Fainelli <florian@openwrt.org>
Date: Mon, 14 Jan 2013 11:52:52 +0100
> The flags argument of the phy_{attach,connect,connect_direct} functions
> is then used to assign a struct phy_device dev_flags with its value.
> All callers but the tg3 driver pass the flag 0, which results in the
> underlying PHY drivers in drivers/net/phy/ not being able to actually
> use any of the flags they would set in dev_flags. This patch gets rid of
> the flags argument, and passes phydev->dev_flags to the internal PHY
> library call phy_attach_direct() such that drivers which actually modify
> a phy device dev_flags get the value preserved for use by the underlying
> phy driver.
>
> Acked-by: Kosta Zertsekel <konszert@marvell.com>
> Signed-off-by: Florian Fainelli <florian@openwrt.org>
Applied, thanks.
prev parent reply other threads:[~2013-01-14 20:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-14 10:52 Florian Fainelli
2013-01-14 20:12 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130114.151214.1296751187134652417.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=afleming@gmail.com \
--cc=florian@openwrt.org \
--cc=konszert@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®